[#319] Added possibility to change default operation timeout. #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszseweryn
requested changes
Nov 16, 2017
| * @throws BleGattCallbackTimeoutException emitted when an internal timeout for connection has been reached. The operation will | ||
| * timeout in direct mode (autoConnect = false) after 35 seconds. | ||
| */ | ||
| Observable<RxBleConnection> establishConnection(ConnectionSetup connectionSetup); |
There was a problem hiding this comment.
I wanted to wait with the signature establishConnection(ConnectionSetup) till the new Connection API will be ready
Reasoning:
establishConnection(ConnectionSetup)is the easiest possible entry point- if we will use it with now—we will not be able to introduce the new
ConnectionAPI without coming up with a new name for the function
Maybe we could use something like Observable<RxBleConnection> establishConnection(boolean autoConnect, TimeoutSetup timeoutSetup) for now?
settings.gradle
Outdated
| @@ -1,3 +1,4 @@ | |||
| include ':rxandroidble', ':mockrxandroidble', ':sample' | |||
| include ':rxandroidble' | |||
There was a problem hiding this comment.
No, a bug. Will revert.
[#319] Added possibility to change default operation timeout.
uKL
force-pushed
the
feature/customizable_operation_timeout
branch
from
571b454
to
ef0139d
Compare
uKL
force-pushed
the
feature/customizable_operation_timeout
branch
from
ef0139d
to
dde7f08
Compare
|
@dariuszseweryn Ready to be checked again. |
1 similar comment
|
@dariuszseweryn Ready to be checked again. |
dariuszseweryn
requested changes
Nov 17, 2017
| * @throws BleGattCallbackTimeoutException emitted when an internal timeout for connection has been reached. The operation will | ||
| * timeout in direct mode (autoConnect = false) after 35 seconds. | ||
| */ | ||
| Observable<RxBleConnection> establishConnection(boolean autoConnect, TimeoutSetup operationTimeoutSetup); |
There was a problem hiding this comment.
Please add @NonNull annotation
| this.timeUnit = timeUnit; | ||
| this.timeout = timeout; | ||
| } | ||
| } |
| public final TimeUnit timeUnit; | ||
| public final long timeout; | ||
|
|
||
| public TimeoutSetup(long timeout, TimeUnit timeUnit) { |
dariuszseweryn
approved these changes
Nov 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#319] Added possibility to change default operation timeout.