Update to Android Studio 3.0 #302

mapyo · 2017-10-31T22:59:59Z

Thank you!

passsy · 2017-11-01T15:46:28Z

gradle/wrapper/gradle-wrapper.properties

 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-3.5-all.zip


use ./gradlew wrapper --gradle-version 4.1 --distribution-type all to upgrade gradle. You did not update the gradle-wrapper.jar

passsy · 2017-11-01T15:47:03Z

gradle/wrapper/gradle-wrapper.properties

 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-3.5-all.zip


4.3 is available, why have you picked 4.1?

I missed the latest version. to correct.

passsy

upgrade gradle wrapper correctly

piotrek1543 · 2017-11-02T07:43:48Z

@passsy what about changing buildToolsVersion to 27.0.0.

Support library version is not updated in that pull request, it's 25.3.1.

uKL · 2017-11-02T07:46:38Z

I'm ok with changing buildToolsVersion to 27.0.0 in the same PR. Good idea.

friederbluemle · 2017-11-02T08:23:11Z

dependencies.gradle

@@ -1,6 +1,6 @@
 ext {
    supportVersion = '25.3.1'
-    buildToolsVersionVariable = "25.0.3"
+    buildToolsVersionVariable = "27.0.0"


You can remove this line, and all three occurrences of buildToolsVersion from the module's build.gradle files. Android Gradle plugin 3.0.0 will automatically pick the right build tools version.

@friederbluemle well, I haven't noticed this... I definitely need to give a try this solution :-)

Oh, I haven't notice this too. Thank you.

https://developer.android.com/studio/releases/build-tools.html

If you're using Android plugin for Gradle 3.0.0 or higher, your project automatically uses a default version of the build tools that the plugin specifies.

I remove this.

When deleting buildToolsVersion, 26.0.2 was used.
I think that it is better to use the latest version if possible. So I specify 27.0.0.

Interesting. I'm all for using the latest version if possible, but to be honest I think since Google implemented (and recommends to use) this auto-chooser, they know best which version to use for a particular Android Gradle plugin and compile/target SDK version combination.

friederbluemle · 2017-11-02T08:23:36Z

gradle/wrapper/gradle-wrapper.properties

 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-3.5-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-4.3-all.zip


Looks good now, can you squash the commits please @mapyo?

We will use Squash and merge option when merging

uKL

It looks like there is some issue compiling Groovy code. Could you take a look?

dariuszseweryn · 2017-11-02T09:33:11Z

Thanks for the PR @mapyo and @friederbluemle @passsy @piotrek1543 for review!
I would like to have two things:

Merge master to this branch so we could use Squash and merge when appropriate
I agree with @uKL that tests should be working before merging this PR. Apparently the Support for Android Gradle Plugin Version 3.0.0 groovy/groovy-android-gradle-plugin#156 is blocking us
We should either wait for a plugin in version 1.3.0 or to workaround the issue somehow?

piotrek1543 · 2017-11-02T10:37:21Z

build.gradle

        jcenter()
    }

    dependencies {
-        classpath 'com.android.tools.build:gradle:2.3.3'
+        classpath 'com.android.tools.build:gradle:3.0.0'
        classpath 'com.github.ben-manes:gradle-versions-plugin:0.14.0'
        classpath 'org.codehaus.groovy:groovy-android-gradle-plugin:1.2.0'


@friederbluemle if @dariuszseweryn is right, maybe temporary changing to classpath 'org.codehaus.groovy:groovy-android-gradle-plugin:1.3.0-SNAPSHOT' would fix groovy compilation errors

Good idea, you could definitely give it a try! Ultimately it's up to you and the maintainers of RxAndroidBle if a snapshot dependency on the master branch is acceptable.
If the update does fix the issue and this is the only problem, maybe we could nudge groovy-android-gradle-plugin to release an official new version soon.

I tried it locally. However, the test did not pass. I think that the change has not been uploaded in the snapshot yet.

http://oss.jfrog.org/oss-snapshot-local/org/codehaus/groovy/groovy-android-gradle-plugin/

1.3.0-SNAPSHOT/ 07-Jun-2017 17:25

- https://travis-ci.org/Polidea/RxAndroidBle/builds/296146431

mapyo · 2017-11-05T09:15:08Z

Thanks for the review @dariuszseweryn @friederbluemle @passsy @piotrek1543 @uKL.

I agree with @uKL that tests should be working before merging this PR. Apparently the groovy/groovy-android-gradle-plugin#156 is blocking us
We should either wait for a plugin in version 1.3.0 or to workaround the issue somehow?

I committed a workaround to pass the test. Please confirm.

uKL

I'm okay with the workaround, nice to have it working again. I'll create an issue so we'll replace the workaround with new plugin version when published.

friederbluemle · 2017-11-06T13:32:31Z

Nice 👍

mapyo · 2017-11-06T16:23:11Z

Thank you 👍

uKL · 2018-03-20T13:36:58Z

Dear Contributor,

similar to many open source projects we kindly request to sign our CLA if you'd like to contribute to our project. This license is for your protection as a Contributor as well as the protection of Polidea; it does not change your rights to use your own Contributions for any other purpose.

You can find a link here: https://cla-assistant.io/Polidea/RxAndroidBle

mapyo changed the title ~~Update Android Studio 3.0~~ Update to Android Studio 3.0 Oct 31, 2017

mapyo force-pushed the update-android-studio-3.0 branch 2 times, most recently from 65d4968 to 202c750 Compare October 31, 2017 23:24

passsy reviewed Nov 1, 2017

View reviewed changes

passsy suggested changes Nov 1, 2017

View reviewed changes

friederbluemle reviewed Nov 2, 2017

View reviewed changes

uKL requested changes Nov 2, 2017

View reviewed changes

piotrek1543 reviewed Nov 2, 2017

View reviewed changes

dariuszseweryn mentioned this pull request Nov 2, 2017

DaggerClientComponent class is undefined #182

Closed

mapyo added 2 commits November 5, 2017 17:50

Update to Android Studio 3.0

9eef9bb

Workaround for pass the test

8ca4fb1

- https://travis-ci.org/Polidea/RxAndroidBle/builds/296146431

mapyo force-pushed the update-android-studio-3.0 branch from d0d4c83 to 8ca4fb1 Compare November 5, 2017 09:57

uKL mentioned this pull request Nov 6, 2017

Replace Android Groovy Plugin workaround with a new plugin version #309

Closed

uKL approved these changes Nov 6, 2017

View reviewed changes

uKL merged commit cc6e24e into dariuszseweryn:master Nov 6, 2017

mapyo deleted the update-android-studio-3.0 branch November 7, 2017 01:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to Android Studio 3.0 #302

Update to Android Studio 3.0 #302

mapyo commented Oct 31, 2017

passsy Nov 1, 2017

passsy Nov 1, 2017

mapyo Nov 2, 2017

passsy left a comment

piotrek1543 commented Nov 2, 2017

uKL commented Nov 2, 2017

friederbluemle Nov 2, 2017 •

edited

Loading

piotrek1543 Nov 2, 2017 •

edited

Loading

mapyo Nov 3, 2017

mapyo Nov 4, 2017

friederbluemle Nov 4, 2017

friederbluemle Nov 2, 2017

dariuszseweryn Nov 2, 2017

uKL left a comment

dariuszseweryn commented Nov 2, 2017

piotrek1543 Nov 2, 2017

friederbluemle Nov 2, 2017 •

edited

Loading

mapyo Nov 3, 2017

mapyo commented Nov 5, 2017

uKL left a comment

friederbluemle commented Nov 6, 2017

mapyo commented Nov 6, 2017

uKL commented Mar 20, 2018

Update to Android Studio 3.0 #302

Update to Android Studio 3.0 #302

Conversation

mapyo commented Oct 31, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

passsy left a comment

Choose a reason for hiding this comment

piotrek1543 commented Nov 2, 2017

uKL commented Nov 2, 2017

friederbluemle Nov 2, 2017 • edited Loading

Choose a reason for hiding this comment

piotrek1543 Nov 2, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

uKL left a comment

Choose a reason for hiding this comment

dariuszseweryn commented Nov 2, 2017

Choose a reason for hiding this comment

friederbluemle Nov 2, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mapyo commented Nov 5, 2017

uKL left a comment

Choose a reason for hiding this comment

friederbluemle commented Nov 6, 2017

mapyo commented Nov 6, 2017

uKL commented Mar 20, 2018

friederbluemle Nov 2, 2017 •

edited

Loading

piotrek1543 Nov 2, 2017 •

edited

Loading

friederbluemle Nov 2, 2017 •

edited

Loading