Added log whilst scan operation is requested to stop #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,6 +33,7 @@ final protected void protectedRun(final Emitter<SCAN_RESULT_TYPE> emitter, Queue | |||
| emitter.setCancellation(new Cancellable() { | |||
| @Override | |||
| public void cancel() throws Exception { | |||
| RxBleLog.v("Scan operation is requested to stop."); | |||
There was a problem hiding this comment.
I am thinking wether it should be an .i() level. We could also use the same level log at the moment of starting the scan.
A .d() level log could be used in a specific scan operation (legacy, api18, api21) that was used
uKL
force-pushed
the
feature/logging_on_scan_stop
branch
from
1860fa8
to
0ada1d6
Compare
dariuszseweryn
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.