-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry mechanism on some BLE stack errors #352
Comments
Hello @martiwi |
@dariuszseweryn I've opened a PR. Please feel free to comment. |
It took some time but we have finally merged #357 — should be available in |
Hi @dariuszseweryn, thank you!!! I don't see it in the |
It should be in the snapshot you've mentioned. |
Hi @uKL from the source within the archive file, it is not unfortunately. Also this file has been generated before the branch being merged into |
I merged it at 9:47 UTC I believe your cache is fooling around :) |
Ok, I've figured out, |
I suppose tomorrow :) We're getting close to a release od RxJava2. FYI, we have gitter for chats :) https://gitter.im/RxBLELibraries/RxAndroidBle |
Summary
This is a proposed enhancement for discussion.
Today, RxAndroidBle does not support retry mechanism, meaning it has to be handled by upper layer from the application.
An interesting enhancement would be to expose an interface that could be implemented by upper layer if some retry should be applied on conditions.
This could be applied mostly for write operations, and especially long write.
Example: It could be possible that on some tiny embedded devices, that incoming messages are not handled as fast as it is sent by the smartphone. Embedded device will then respond with a
GATT_INSUF_RESOURCE 0x11
and instead of just failing the all payload, a simple retry would be good enough to have it working.Library version
1.4.3
Actual result
Today, the request is canceled, and for a long write, you will have to retry and mostly facing the same issue next time. Thus, the payload can't be sent.
Expected result
Upper layer implement a retry interface, and check if for example, BLE stack error code is worth a retry.
The text was updated successfully, but these errors were encountered: