Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxJava 1.3.1 bug preventing RxAndroidBle from building with ProGuard #312

Closed
mechatronik opened this issue Nov 9, 2017 · 3 comments
Closed
Assignees
Labels
bug Bug that is caused by the library

Comments

@mechatronik
Copy link
Contributor

Summary

There is a bug in RxJava 1.3.1 (which this lib is dependent on) fixed in RxJava 1.3.2, which prevented us from building our project with ProGuard enabled. RxJavaProGuardRules author recommends skipping this version of RxJava. When we exclude rxjava bundled with rxandroidble from gradle and replace it with newer version, everything works fine.

Library version

1.4.0 and above

Actual result

Warning:rx.internal.schedulers.NewThreadWorker: can't find referenced method 'java.util.concurrent.ConcurrentHashMap$KeySetView keySet()' in library class java.util.concurrent.ConcurrentHashMap
Warning:there were 1 unresolved references to library class members.
Error:Execution failed for task ':app:transformClassesAndResourcesWithProguardForDebug'

Expected result

Build succeeds

@uKL uKL self-assigned this Nov 9, 2017
@uKL uKL added the bug Bug that is caused by the library label Nov 9, 2017
@uKL
Copy link
Collaborator

uKL commented Nov 9, 2017

Good spot! Could you make a pull request bumping rxjava to 1.3.2?

@mechatronik
Copy link
Contributor Author

Probably later today

@uKL
Copy link
Collaborator

uKL commented Nov 9, 2017

Thanks!

mechatronik added a commit to mechatronik/RxAndroidBle that referenced this issue Nov 9, 2017
@uKL uKL closed this as completed in d7156a4 Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug that is caused by the library
Projects
None yet
Development

No branches or pull requests

2 participants