Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packets 21 and 149 - Fetch Friend Favorite Game Server List #46

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

desukuran
Copy link
Contributor

  • Preliminary adding, it reads and sends as it should but no real data is sent, just enough to satisfy xfire awaiting something.
  • This packet deals with fetching all game server information based on Game ID and Friend Favorites.

Added Inbound Packet GameServerFetchFriendsFavorites (21)

  • It only expects a gameid. From there the server sends back GameServerSendFriendsFavorites packet. (Weirdly enough, this one uses the string "gameid" unlike the All packet.)

Added Outbound Packet GameServerSendFriendsFavorites (149)

  • Four attributes are sent: gameid, a list of gameips and a list of gameports (both iterates in sync), list of a list of ints for FriendIds.
  • I have added as such for future addition: It makes the lists but doesn't populate them and sends back the GameId sent by the client.
  • The FriendIds nested list is a weird one, only ever used again in FriendofFriends. I had to make a list of userids and then put it inside of FriendIds. I don't know why they designed it as such, as vanilla xfire doesn't use this information at all it seems...

XFireMessageType and XFireMessageTypeFactory adds the packets to the lists as needed.

* Preliminary adding, it reads and sends as it should but no real data is sent, just enough to satisfy xfire awaiting something.
* This packet deals with fetching all game server information based on Game ID and Friend Favorites.

Added Inbound Packet GameServerFetchFriendsFavorites (21)
 * It only expects a gameid. From there the server sends back GameServerSendFriendsFavorites packet. (Weirdly enough, this one uses the string "gameid" unlike the All packet.)

Added Outbound Packet GameServerSendFriendsFavorites (149)
 * Four attributes are sent: gameid, a list of gameips and a list of gameports (both iterates in sync), list of a list of ints for FriendIds.
 * I have added as such for future addition: It makes the lists but doesn't populate them and sends back the GameId sent by the client.
 * The FriendIds nested list is a weird one, only ever used again in FriendofFriends. I had to make a list of userids and then put it inside of FriendIds. I don't know why they designed it as such, as vanilla xfire doesn't use this information at all it seems...

XFireMessageType and XFireMessageTypeFactory adds the packets to the lists as needed.
Copy link
Owner

@darcymiranda darcymiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@darcymiranda darcymiranda merged commit 017656e into darcymiranda:master Mar 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants