0x02 Attribute is possibly unsigned. Made all Signed Ints are now Unsigned.

src/PFire.Core/Models/FriendRequestModel.cs

@@ -2,7 +2,7 @@
 {
     public class FriendRequestModel
     {
-        public int Id { get; set; }
+        public uint Id { get; set; }
         public string Username { get; set; }
         public string Nickname { get; set; }
         public string Message { get; set; }

src/PFire.Core/Models/GameModel.cs

@@ -8,8 +8,8 @@ namespace PFire.Core.Models
 {
     public class GameModel
     {
-        public int Id { get; set; }
-        public int Ip { get; set; }
-        public int Port { get; set; }
+        public uint Id { get; set; }
+        public uint Ip { get; set; }
+        public uint Port { get; set; }
     }
 }

src/PFire.Core/Models/User.cs

@@ -2,7 +2,7 @@
 {
     public class UserModel
     {
-        public int Id { get; set; }
+        public uint Id { get; set; }
         public string Username { get; set; }
         public string Password { get; set; }
         public string Nickname { get; set; }

src/PFire.Core/Protocol/Messages/Bidirectional/ChatContent.cs

@@ -5,7 +5,7 @@ internal sealed class ChatContent : XFireMessage
         public ChatContent() : base(XFireMessageType.ServerChatMessage) {}
 
         [XMessageField("imindex")]
-        public int MessageOrderIndex { get; set; }
+        public uint MessageOrderIndex { get; set; }
 
         [XMessageField("im")]
         public string MessageContent { get; set; }

src/PFire.Core/Protocol/Messages/Bidirectional/ChatMessage.cs

@@ -79,7 +79,7 @@ private ChatMessage BuildAckResponse(Guid sessionId)
                 MessagePayload = new Dictionary<string, dynamic>
                 {
                     {"msgtyp", (byte)ChatMessageType.Acknowledgement},
-                    {"imindex", (int)MessagePayload["imindex"]}
+                    {"imindex", (uint)MessagePayload["imindex"]}
                 }
             };
         }

src/PFire.Core/Protocol/Messages/Bidirectional/ChatTypingNotification.cs

@@ -8,9 +8,9 @@ internal sealed class ChatTypingNotification : XFireMessage
         public ChatTypingNotification() : base(XFireMessageType.ServerChatMessage) {}
 
         [XMessageField("imindex")]
-        public int OrderIndex { get; set; }
+        public uint OrderIndex { get; set; }
 
         [XMessageField("typing")]
-        public int Typing { get; set; }
+        public uint Typing { get; set; }
     }
 }

src/PFire.Core/Protocol/Messages/Inbound/ClientVersion.cs

@@ -9,10 +9,10 @@ internal sealed class ClientVersion : XFireMessage
         public ClientVersion() : base(XFireMessageType.ClientVersion) {}
 
         [XMessageField("version")]
-        public int Version { get; set; }
+        public uint Version { get; set; }
 
         [XMessageField("major_version")]
-        public int MajorVersion { get; set; }
+        public uint MajorVersion { get; set; }
 
         public override async Task Process(IXFireClient context)
         {

src/PFire.Core/Protocol/Messages/Inbound/ConnectionInformation.cs

@@ -10,19 +10,19 @@ internal sealed class ConnectionInformation : XFireMessage
         public ConnectionInformation() : base(XFireMessageType.ConnectionInformation) {}
 
         [XMessageField("conn")]
-        public int Connection { get; set; }
+        public uint Connection { get; set; }
 
         [XMessageField("nat")]
-        public int Nat { get; set; }
+        public uint Nat { get; set; }
 
         [XMessageField("naterr")]
-        public int NatError { get; set; }
+        public uint NatError { get; set; }
 
         [XMessageField("sec")]
-        public int Sec { get; set; }
+        public uint Sec { get; set; }
 
         [XMessageField("clientip")]
-        public int ClientIp { get; set; }
+        public uint ClientIp { get; set; }
 
         [XMessageField("upnpinfo")]
         public string UpnpInfo { get; set; }

src/PFire.Core/Protocol/Messages/Inbound/FriendRemoval.cs

@@ -9,7 +9,7 @@ internal sealed class FriendRemoval : XFireMessage
         public FriendRemoval() : base(XFireMessageType.FriendRemoval) { }
 
         [XMessageField("userid")]
-        public int UserId { get; set; }
+        public uint UserId { get; set; }
 
         public override async Task Process(IXFireClient context)
         {

src/PFire.Core/Protocol/Messages/Inbound/GameInformation.cs

@@ -10,13 +10,13 @@ internal sealed class GameInformation : XFireMessage
         public GameInformation() : base(XFireMessageType.GameInformation) {}
 
         [XMessageField("gameid")]
-        public int GameId { get; set; }
+        public uint GameId { get; set; }
 
         [XMessageField("gip")]
-        public int GameIP { get; set; }
+        public uint GameIP { get; set; }
 
         [XMessageField("gport")]
-        public int GamePort { get; set; }
+        public uint GamePort { get; set; }
 
         public override async Task Process(IXFireClient context)
         {

src/PFire.Core/Protocol/Messages/Inbound/LoginRequest.cs

@@ -15,7 +15,7 @@ public LoginRequest() : base(XFireMessageType.LoginRequest) {}
         public string Password { get; set; }
 
         [XMessageField("flags")]
-        public int Flags { get; set; }
+        public uint Flags { get; set; }
 
         public override async Task Process(IXFireClient context)
         {

src/PFire.Core/Protocol/Messages/Outbound/ChatRooms.cs

@@ -6,10 +6,10 @@ internal sealed class ChatRooms : XFireMessage
     {
         public ChatRooms() : base(XFireMessageType.ChatRooms)
         {
-            ChatIds = new List<int>();
+            ChatIds = new List<uint>();
         }
 
         [XMessageField(0x04)]
-        public List<int> ChatIds { get; }
+        public List<uint> ChatIds { get; }
     }
 }

src/PFire.Core/Protocol/Messages/Outbound/FriendRemoved.cs

@@ -5,12 +5,12 @@ namespace PFire.Core.Protocol.Messages.Outbound
 {
     internal sealed class FriendRemoved : XFireMessage
     {
-        public FriendRemoved(int userId) : base(XFireMessageType.FriendRemoved)
+        public FriendRemoved(uint userId) : base(XFireMessageType.FriendRemoved)
         {
             UserId = userId;
         }
 
         [XMessageField("userid")]
-        public int UserId { get; set; }
+        public uint UserId { get; set; }
     }
 }

src/PFire.Core/Protocol/Messages/Outbound/FriendsGameInfo.cs

@@ -18,22 +18,22 @@ public FriendsGamesInfo(UserModel owner) : base(XFireMessageType.FriendsGameInfo
         {
             _ownerUser = owner;
             SessionIds = new List<Guid>();
-            GameID = new List<int>();
-            GameIP = new List<int>();
-            GamePort = new List<int>();
+            GameID = new List<uint>();
+            GameIP = new List<uint>();
+            GamePort = new List<uint>();
         }
 
         [XMessageField("sid")]
         public List<Guid> SessionIds { get; set; }
 
         [XMessageField("gameid")]
-        public List<int> GameID { get; set; }
+        public List<uint> GameID { get; set; }
 
         [XMessageField("gip")]
-        public List<int> GameIP { get; set; }
+        public List<uint> GameIP { get; set; }
 
         [XMessageField("gport")]
-        public List<int> GamePort { get; set; }
+        public List<uint> GamePort { get; set; }
 
         public override Task Process(IXFireClient client)
         {

src/PFire.Core/Protocol/Messages/Outbound/FriendsList.cs

@@ -13,13 +13,13 @@ public FriendsList(UserModel owner) : base(XFireMessageType.FriendsList)
         {
             _ownerUser = owner;
 
-            UserIds = new List<int>();
+            UserIds = new List<uint>();
             Usernames = new List<string>();
             Nicks = new List<string>();
         }
 
         [XMessageField("userid")]
-        public List<int> UserIds { get; }
+        public List<uint> UserIds { get; }
 
         [XMessageField("friends")]
         public List<string> Usernames { get; }

src/PFire.Core/Protocol/Messages/Outbound/FriendsSessionAssign.cs

@@ -15,12 +15,12 @@ internal sealed class FriendsSessionAssign : XFireMessage
         public FriendsSessionAssign(UserModel owner) : base(XFireMessageType.FriendsSessionAssign)
         {
             _ownerUser = owner;
-            UserIds = new List<int>();
+            UserIds = new List<uint>();
             SessionIds = new List<Guid>();
         }
 
         [XMessageField("userid")] 
-        public List<int> UserIds { get; }
+        public List<uint> UserIds { get; }
 
         [XMessageField("sid")] 
         public List<Guid> SessionIds { get; }

src/PFire.Core/Protocol/Messages/Outbound/Groups.cs

@@ -9,14 +9,14 @@ internal sealed class Groups : XFireMessage
         public Groups() : base(XFireMessageType.Groups) {}
 
         [XMessageField(0x19)]
-        public List<int> GroupIds { get; set; }
+        public List<uint> GroupIds { get; set; }
 
         [XMessageField(0x1a)]
         public List<string> GroupNames { get; set; }
 
         public override Task Process(IXFireClient context)
         {
-            GroupIds = new List<int>();
+            GroupIds = new List<uint>();
             GroupNames = new List<string>();
 
             return Task.CompletedTask;

src/PFire.Core/Protocol/Messages/Outbound/GroupsFriends.cs

@@ -6,14 +6,14 @@ internal sealed class GroupsFriends : XFireMessage
     {
         public GroupsFriends() : base(XFireMessageType.GroupsFriends)
         {
-            UserIds = new List<int>();
-            GroupIds = new List<int>();
+            UserIds = new List<uint>();
+            GroupIds = new List<uint>();
         }
 
         [XMessageField(0x01)]
-        public List<int> UserIds { get; }
+        public List<uint> UserIds { get; }
 
         [XMessageField(0x19)]
-        public List<int> GroupIds { get; }
+        public List<uint> GroupIds { get; }
     }
 }

src/PFire.Core/Protocol/Messages/Outbound/LoginFailure.cs

@@ -5,6 +5,6 @@ internal sealed class LoginFailure : XFireMessage
         public LoginFailure() : base(XFireMessageType.LoginFailure) {}
 
         [XMessageField("reason")]
-        public int Reason { get; set; }
+        public uint Reason { get; set; }
     }
 }

src/PFire.Core/Protocol/Messages/Outbound/LoginSuccess.cs

@@ -11,7 +11,7 @@ internal sealed class LoginSuccess : XFireMessage
         public LoginSuccess() : base(XFireMessageType.LoginSuccess) {}
 
         [XMessageField("userid")]
-        public int UserId { get; set; }
+        public uint UserId { get; set; }
 
         [XMessageField("sid")]
         public Guid SessionId { get; set; }
@@ -20,7 +20,7 @@ public LoginSuccess() : base(XFireMessageType.LoginSuccess) {}
         public string Nickname { get; set; }
 
         [XMessageField("status")]
-        public int Status { get; set; }
+        public uint Status { get; set; }
 
         [XMessageField("dlset")]
         public string DlSet { get; set; }
@@ -32,25 +32,25 @@ public LoginSuccess() : base(XFireMessageType.LoginSuccess) {}
         public string ClientSet { get; set; }
 
         [XMessageField("minrect")]
-        public int MinRect { get; set; }
+        public uint MinRect { get; set; }
 
         [XMessageField("maxrect")]
-        public int MaxRect { get; set; }
+        public uint MaxRect { get; set; }
 
         [XMessageField("ctry")]
-        public int Country { get; set; }
+        public uint Country { get; set; }
 
         [XMessageField("n1")]
-        public int N1 { get; set; }
+        public uint N1 { get; set; }
 
         [XMessageField("n2")]
-        public int N2 { get; set; }
+        public uint N2 { get; set; }
 
         [XMessageField("n3")]
-        public int N3 { get; set; }
+        public uint N3 { get; set; }
 
         [XMessageField("pip")]
-        public int PublicIp { get; set; }
+        public uint PublicIp { get; set; }
 
         [XMessageField("salt")]
         public string Salt { get; set; }
@@ -67,7 +67,7 @@ public override Task Process(IXFireClient context)
             MinRect = 1;
             MaxRect = 164867;
             var ipAddress = StripPortFromIpAddress(context.RemoteEndPoint.ToString());
-            PublicIp = BitConverter.ToInt32(IPAddress.Parse(ipAddress).GetAddressBytes(), 0);
+            PublicIp = BitConverter.ToUInt32(IPAddress.Parse(ipAddress).GetAddressBytes(), 0);
             Salt = context.Salt;
             Reason = "Mq_P8Ad3aMEUvFinw0ceu6FITnZTWXxg46XU8xHW";
 

src/PFire.Core/Protocol/Messages/Outbound/ServerList.cs

@@ -6,21 +6,21 @@ internal sealed class ServerList : XFireMessage
     {
         public ServerList() : base(XFireMessageType.ServerList)
         {
-            GameIds = new List<int>();
-            GameIPs = new List<int>();
-            GamePorts = new List<int>();
+            GameIds = new List<uint>();
+            GameIPs = new List<uint>();
+            GamePorts = new List<uint>();
         }
 
         [XMessageField("max")]
-        public int MaximumFavorites { get; set; }
+        public uint MaximumFavorites { get; set; }
 
         [XMessageField("gameid")]
-        public List<int> GameIds { get; }
+        public List<uint> GameIds { get; }
 
         [XMessageField("gip")]
-        public List<int> GameIPs { get; }
+        public List<uint> GameIPs { get; }
 
         [XMessageField("gport")]
-        public List<int> GamePorts { get; }
+        public List<uint> GamePorts { get; }
     }
 }

src/PFire.Core/Protocol/Messages/Outbound/ServerPong.cs

@@ -18,7 +18,7 @@ internal sealed class ServerPong : XFireMessage
         public ServerPong() : base(XFireMessageType.ServerPong) { }
 
         [XMessageField("value")]
-        public int Value { get; set; } = 0;
+        public uint Value { get; set; } = 0;
 
         public override Task Process(IXFireClient context)
         {

src/PFire.Core/Protocol/XFireAttributeFactory.cs

@@ -16,7 +16,8 @@ public class XFireAttributeFactory
         private XFireAttributeFactory()
         {
             Add(new StringAttribute());
-            Add(new Int32Attribute());
+            //Add(new Int32Attribute());
+            Add(new UInt32Attribute());
             Add(new SessionIdAttribute());
             Add(new ListAttribute());
             Add(new DidAttribute());

src/PFire.Core/Protocol/XFireAttributes/MessageAttribute.cs

@@ -9,13 +9,13 @@ namespace PFire.Core.Protocol.XFireAttributes
 {
     public class MessageAttribute : XFireAttribute
     {
-        private static readonly Dictionary<int, IMessage> MESSAGE_TYPES = new Dictionary<int, IMessage>
+        private static readonly Dictionary<uint, IMessage> MESSAGE_TYPES = new Dictionary<uint, IMessage>
         {
             { 0, new ChatMessage() },
             { 1, new ChatAcknowledgement() }
         };
 
-        private IMessage CreateMessage(short type)
+        private IMessage CreateMessage(uint type)
         {
             if(!MESSAGE_TYPES.ContainsKey(type))
             {
@@ -55,4 +55,4 @@ private string ReadInt8String(BinaryReader reader)
             return Encoding.UTF8.GetString(reader.ReadBytes(length));
         }
     }
-}
+}