Skip to content

Groundwork for future .NET 6 upgrade#8

Merged
tylerkron merged 28 commits intomainfrom
6-upgrade-to-net-6
Aug 29, 2022
Merged

Groundwork for future .NET 6 upgrade#8
tylerkron merged 28 commits intomainfrom
6-upgrade-to-net-6

Conversation

@tylerkron
Copy link
Copy Markdown
Contributor

The upgrade was huge, so this is an incremental step. Updated a bunch of libs along the way

@tylerkron tylerkron linked an issue Aug 26, 2022 that may be closed by this pull request
Comment thread .gitignore
bin
obj
AnalysisReport.sarif
debug.log
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be checked in?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, should not be

Copy link
Copy Markdown
Contributor

@danmiller973 danmiller973 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but are there any changes we need to make in the installer (i.e. .net framework checks)?

@tylerkron
Copy link
Copy Markdown
Contributor Author

@danmiller973 yes likely a ton of updates for the installer. I'll make those in a new PR

@tylerkron tylerkron merged commit ae042d1 into main Aug 29, 2022
@tylerkron tylerkron deleted the 6-upgrade-to-net-6 branch August 29, 2022 02:12
tylerkron added a commit that referenced this pull request Apr 19, 2026
Save-image and zoom buttons previously floated over the plot,
overlapping the rightmost axis ticks and sitting on top of the data.
Moved them into the right side of the session header strip so the
plot area shows data only (principle #1) and all plot chrome lives
in one row (principle #8). Swapped the Y-zoom magnifier icons for
vertical expand/collapse arrows so X-zoom and Y-zoom read as
different axes at a glance.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to .NET 6

2 participants