chore: remove redundant Google.Protobuf package references#537
Merged
Conversation
DataModel, IO, and Test each pinned a direct Google.Protobuf 3.34.1 reference, but none need it directly: DataModel and IO use no protobuf types, and Test (like the main app and IO.Test, which carry no direct reference) gets DaqifiOutMessage transitively from Daqifi.Core, which declares Google.Protobuf as a public dependency. These stale pins caused the NU1605 package-downgrade failure in #533, where a grouped Dependabot bump moved Protobuf to 3.35.0 in DataModel and IO but left Test at 3.34.1. Removing them lets Google.Protobuf track Daqifi.Core's version and prevents this class of Dependabot desync. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Review Summary by QodoRemove redundant Google.Protobuf package references
WalkthroughsDescription• Remove redundant Google.Protobuf direct references from three projects • Protobuf dependency flows transitively from Daqifi.Core as public dependency • Fixes NU1605 package-downgrade error caused by Dependabot version desync • Prevents future Dependabot conflicts by letting Protobuf track Core's version Diagramflowchart LR
A["Daqifi.Core<br/>Google.Protobuf 3.35.0<br/>public dependency"] -->|"transitive"| B["DataModel"]
A -->|"transitive"| C["IO"]
A -->|"transitive"| D["Test"]
E["Before: Direct refs<br/>3.34.1 in each"] -.->|"removed"| B
E -.->|"removed"| C
E -.->|"removed"| D
File Changes1. Daqifi.Desktop.DataModel/Daqifi.Desktop.DataModel.csproj
|
Contributor
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require review |
📊 Code Coverage ReportSummarySummary
CoverageDAQiFi - 19.1%
Daqifi.Desktop.Common - 30.8%
Daqifi.Desktop.IO - 100%
Coverage report generated by ReportGenerator • View full report in build artifacts |
This was referenced Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the direct
Google.ProtobufPackageReference from three projects that do not use it directly:Daqifi.Desktop.DataModelDaqifi.Desktop.IODaqifi.Desktop.TestWhy
Protobuf handling lives in the external Daqifi.Core package, which declares
Google.Protobufas a public dependency — so it already flows transitively to every project that references Core. These three direct references were leftover cruft from when this repo had its own.protocodegen, which is now fully removed (no.protofiles, noGrpc.Tools, no<Protobuf>MSBuild items remain).Google.Protobuftypes.DaqifiOutMessage(and itsRepeatedField/ByteStringmembers) transitively from Core — exactly like the mainDaqifi.Desktopapp andDaqifi.Desktop.IO.Test, neither of which carries a direct reference.Fixes the failure in #533
These stale pins are the root cause of the
NU1605package-downgrade error in #533. The grouped Dependabot bump moved Protobuf3.34.1 -> 3.35.0in DataModel and IO but leftDaqifi.Desktop.Testat3.34.1. Because a direct reference always overrides a transitive one, NuGet treated the Test pin as a downgrade of the version Core requires and faileddotnet restore.With the direct references gone,
Google.Protobufsimply tracks whatever version Daqifi.Core ships, and this class of Dependabot desync cannot recur. After this merges, #533 should rebase down to just thecoverlet.collectorandSystem.Managementbumps and go green.🤖 Generated with Claude Code