Skip to content

feat: redesign Profiles pane following design philosophy #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tylerkron merged 8 commits into from
Apr 19, 2026
Merged

feat: redesign Profiles pane following design philosophy #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6a75578
feat: redesign Profiles pane following design philosophy
tylerkron Apr 18, 2026
a643794
chore: tighten Profiles pane and remove dead pre-redesign code
tylerkron Apr 18, 2026
939b660
Merge remote-tracking branch 'origin/main' into claude/hungry-hamilto…
tylerkron Apr 18, 2026
1c85203
fix: null Channels crash when activating profile with empty-channel d…
tylerkron Apr 18, 2026
62c5102
fix(profiles): cap frequency at 1000Hz and confirm-then-switch active…
tylerkron Apr 18, 2026
18b7f04
feat(profiles): in-pane dark confirm dialog for profile switch
tylerkron Apr 18, 2026
4f036ed
Merge branch 'main' into claude/hungry-hamilton-ce793b
tylerkron Apr 18, 2026
2386e3d
refactor(profiles): address Qodo review feedback
tylerkron Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Daqifi.Desktop/Loggers/LoggingManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,13 +352,16 @@ public List<Profile> LoadProfilesFromXml()
MacAddress = (string)d.Element("MACAddress"),
DeviceSerialNo = (string)d.Element("DeviceSerialNo"),
SamplingFrequency = (int)d.Element("SamplingFrequency"),
// The writer omits <Channels> when the device has no active channels
// (see UpdateProfileInXml / AddAndRemoveProfileXml). Default to an empty
// list so downstream code can call .Where/.Select without a null check.
Channels = d.Element("Channels")?.Elements("Channel").Select(c => new ProfileChannel
{
Name = (string)c.Element("Name"),
Type = (string)c.Element("Type"),
IsChannelActive = (bool)c.Element("IsActive"),
SerialNo = (string)d.Element("DeviceSerialNo")
}).ToList()
}).ToList() ?? []
}).ToList())
}).ToList();

Expand Down
84 changes: 1 addition & 83 deletions Daqifi.Desktop/MainWindow.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,6 @@
<!-- Live Graph Flyout -->
<flyouts:LiveGraphFlyout DataContext="{Binding DataContext, RelativeSource={RelativeSource AncestorType=controls:MetroWindow}}"/>

<!-- Update Profile Flyout -->
<flyouts:UpdateProfileFlyout DataContext="{Binding DataContext, RelativeSource={RelativeSource AncestorType=controls:MetroWindow}}"/>

<!-- Logging Session Settings Flyout-->
<flyouts:LoggedSessionFlyout DataContext="{Binding DataContext, RelativeSource={RelativeSource AncestorType=controls:MetroWindow}}"/>

Expand Down Expand Up @@ -1099,86 +1096,7 @@
<ContentPresenter Content="{Binding}">
<ContentPresenter.ContentTemplate>
<DataTemplate>
<Grid>
<ListView Name="ActiveProfileList" ItemsSource="{Binding Profiles}" SelectionMode="Single" Background="Transparent" BorderThickness="0" SelectedItem="{Binding SelectedProfile, Mode=OneWayToSource}">
<ListView.ItemTemplate>
<DataTemplate>
<Border Height="50">
<Grid>
<Grid.ColumnDefinitions>
<ColumnDefinition Width="*"/>
<ColumnDefinition Width="Auto"/>
<ColumnDefinition Width="Auto"/>
<ColumnDefinition Width="Auto"/>
<ColumnDefinition Width="Auto"/>
</Grid.ColumnDefinitions>
<StackPanel Grid.Column="0" VerticalAlignment="Center" Orientation="Horizontal">
<Ellipse Width="16" Height="16" VerticalAlignment="Center" Margin="5,5,5,0">
<Ellipse.Style>
<Style TargetType="Ellipse">
<Setter Property="Fill" Value="IndianRed"/>

<Style.Triggers>
<DataTrigger Binding="{Binding IsProfileActive}" Value="True">
<Setter Property="Fill" Value="LightGreen"/>

</DataTrigger>
</Style.Triggers>
</Style>
</Ellipse.Style>
</Ellipse>

<!-- Name Label -->
<Label Content="{Binding Name}" FontWeight="DemiBold" FontSize="16" Padding="5,0,0,0"/>
<Label Content="{Binding CreatedOn}" FontWeight="DemiBold" Foreground="LightGray" FontSize="10" Padding="20,5,0,0"/>

</StackPanel>
<Button Grid.Column="1" HorizontalAlignment="Right" VerticalAlignment="Center" Command="{Binding ElementName=ActiveProfileList, Path=DataContext.OpenProfileSettingsCommand}" CommandParameter="{Binding}" ToolTip="Profile Settings">
<Button.Content>
<iconPacks:PackIconMaterial Kind="Cog" HorizontalAlignment="Center" Height="20" Width="20"/>
</Button.Content>
</Button>
<Button Grid.Column="2" HorizontalAlignment="Right" VerticalAlignment="Center" Command="{Binding ElementName=ActiveProfileList, Path=DataContext.RemoveProfileCommand}" CommandParameter="{Binding}" ToolTip="Delete Profile">
<Button.Content>
<iconPacks:PackIconMaterial Kind="TrashCanOutline" HorizontalAlignment="Center" Height="20" Width="20"/>
</Button.Content>
</Button>
<Button Grid.Column="3" HorizontalAlignment="Right" VerticalAlignment="Center" Command="{Binding ElementName=ActiveProfileList, Path=DataContext.ActivateProfileCommand}" CommandParameter="{Binding}" ToolTip="Active Profile">
<Button.Content>
<iconPacks:PackIconMaterial Kind="CheckCircle" HorizontalAlignment="Center" Height="20" Width="20"/>
</Button.Content>
</Button>
</Grid>
</Border>
</DataTemplate>
</ListView.ItemTemplate>
</ListView>
<Border Name="EmptyActiveProfileListLabel" Visibility="Collapsed" HorizontalAlignment="Stretch" VerticalAlignment="Stretch">
<Label HorizontalAlignment="Stretch" HorizontalContentAlignment="Center" VerticalAlignment="Stretch" VerticalContentAlignment="Center">
<Label.Content>
<StackPanel Orientation="Vertical" Width="150" HorizontalAlignment="Center" VerticalAlignment="Center">
<Label Content="No Profiles Data" VerticalContentAlignment="Center" HorizontalContentAlignment="Center"/>
</StackPanel>
</Label.Content>
</Label>
</Border>

<!-- Add profile Button -->
<Button HorizontalAlignment="Right" VerticalAlignment="Bottom" Width="50" Height="50" Command="{Binding ShowAddProfileConfirmationCommand}" Style="{DynamicResource MetroCircleButtonStyle}" Margin="10" Background="#CC119EDA" >
<Button.Content>
<iconPacks:PackIconMaterial Kind="Plus" HorizontalAlignment="Center" Height="20" Width="20" Foreground="White"/>
</Button.Content>
<Button.BitmapEffect>
<DropShadowBitmapEffect Color="Black" Direction="270" Softness="1" ShadowDepth="15" Opacity="0.25" />
</Button.BitmapEffect>
</Button>
</Grid>
<DataTemplate.Triggers>
<DataTrigger Binding="{Binding Profiles.Count}" Value="0">
<Setter TargetName="ActiveProfileList" Property="Visibility" Value="Collapsed"/>
<Setter TargetName="EmptyActiveProfileListLabel" Property="Visibility" Value="Visible"/>
</DataTrigger>
</DataTemplate.Triggers>
<local:ProfilesPane/>
</DataTemplate>
</ContentPresenter.ContentTemplate>
</ContentPresenter>
Expand Down
18 changes: 0 additions & 18 deletions Daqifi.Desktop/View/AddProfileConfirmationDialog.xaml
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions Daqifi.Desktop/View/AddProfileConfirmationDialog.xaml.cs
View file
Open in desktop

This file was deleted.

82 changes: 0 additions & 82 deletions Daqifi.Desktop/View/AddprofileDialog.xaml
View file
Open in desktop

This file was deleted.

81 changes: 0 additions & 81 deletions Daqifi.Desktop/View/AddprofileDialog.xaml.cs
View file
Open in desktop

This file was deleted.

Loading
Loading