feat: expand SCPI message producer with comprehensive command support#5
Merged
feat: expand SCPI message producer with comprehensive command support#5
Conversation
Added multiple SCPI command messages to the `ScpiMessageProducer` class, including device control, logging, streaming, and network configuration commands. Updated unit tests to reflect new method names and ensure correct command generation.
tylerkron
added a commit
that referenced
this pull request
Apr 25, 2026
- Averaging now flushes a final partial window when the sample count isn't a multiple of AverageWindow; previously trailing samples were silently dropped (Qodo #2). - INVALID({ticks}) fallback now applies in both absolute and relative time modes; previously relative mode skipped the invalid-tick check entirely and emitted a numeric offset for out-of-range ticks (#7). - ExportAsync now calls cancellationToken.ThrowIfCancellationRequested() before writing the CSV header, preventing header-only output for a pre-cancelled token (#8). - ArgumentOutOfRangeException for invalid AverageWindow now reports paramName as "options.AverageWindow" instead of "options" (#9). - Test for "G" formatting now compares against InvariantCulture, matching the exporter's invariant output and avoiding failures on de-DE etc. (#5). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added multiple SCPI command messages to the
ScpiMessageProducerclass, including device control, logging, streaming, and network configuration commands. Updated unit tests to reflect new method names and ensure correct command generation.closes #3