Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for Input and output Bindings #57

Merged
merged 9 commits into from
Jul 6, 2024

Conversation

rafamerlin
Copy link
Contributor

Hi, I'm not very good with rust yet so I am happy to receive any feedback. I mostly copied the other example and made some small changes to make the bindings to work. Tested using ServiceBus and they work fine.

One thing to note is that I had to add a couple of properties missing in the client.rs file, that's the only change that could impact something else, it wasn't working before this changes though so hopefully this is an update to match the proto file.

This probably helps a bit with this request: #48

@ghost
Copy link

ghost commented Sep 28, 2021

CLA assistant check
All CLA requirements met.

metadata:
name: binding-example
spec:
type: bindings.azure.servicebusqueues
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the Dapr examples rely on the components that are locally installed with dapr init, meaning Redis. Can you change the pub/sub component to use Redis?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafamerlin are you able to make the suggested change? If you're too busy, I'm happy to do it and raise the PR (keeping your changes attributed to you of course).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaron2 I don't get any default components installed with dapr init --slim.
Should the component just be removed from the example (the other examples don't have one)?
Or, should it just be copy/pasted from here: https://docs.dapr.io/reference/components-reference/supported-bindings/redis/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NickLarsenNZ - The examples are usually based off dapr init or dapr init -k --dev
A good starting point would be here: https://github.com/dapr/go-sdk/tree/main/examples/service/config
I'm looking to get all the examples validating as part of a new github actions workflow using dapr/mechanical-markdown

Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label May 18, 2024
Copy link

This pull request has been automatically closed because it has not had activity in the last 67 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this May 25, 2024
@mikeee mikeee reopened this May 25, 2024
@mikeee mikeee requested review from a team as code owners May 25, 2024 20:00
@github-actions github-actions bot removed the stale label May 25, 2024
@mikeee mikeee mentioned this pull request Jun 28, 2024
@mikeee mikeee enabled auto-merge July 6, 2024 17:55
@mikeee mikeee disabled auto-merge July 6, 2024 17:55
@mikeee mikeee merged commit 5764c6c into dapr:main Jul 6, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants