Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Cryptography API #144

Merged
merged 19 commits into from
Mar 25, 2024
Merged

Implement Cryptography API #144

merged 19 commits into from
Mar 25, 2024

Conversation

zedgell
Copy link
Contributor

@zedgell zedgell commented Mar 20, 2024

Description

Add Cryptography API to the GRPC client and created example

Issue reference

This PR will close #133

Checklist

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@zedgell
Added Crypto functionality.
02e8f03 
Signed-off-by: Zachary Edgell <[email protected]>
@zedgell
Merge remote-tracking branch 'origin/master' into feature/crypto
17671f0 
# Conflicts:
#	Cargo.toml
@zedgell
Added README.md
a0b154d 
Signed-off-by: Zachary Edgell <[email protected]>
@zedgell
Code Formatting
28f33f2 
Signed-off-by: Zachary Edgell <[email protected]>
@zedgell zedgell requested review from a team as code owners March 20, 2024 09:56
@mikeee
Copy link
Member

mikeee commented Mar 20, 2024

@zedgell Amazing! I will block out some time today to review this!

mikeee
mikeee reviewed Mar 20, 2024
View reviewed changes
Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small addition - will need to be added to the workflow manually:
.github/workflows/validate-examples.yml

@zedgell
Copy link
Contributor Author

zedgell commented Mar 22, 2024

Just a small addition - will need to be added to the workflow manually: .github/workflows/validate-examples.yml

@mikeee It is added now.

mikeee
mikeee reviewed Mar 22, 2024
View reviewed changes
examples/crypto/README.md Outdated Show resolved Hide resolved
mikeee
mikeee reviewed Mar 22, 2024
View reviewed changes
src/crypto.rs Outdated Show resolved Hide resolved
mikeee
mikeee requested changes Mar 24, 2024
View reviewed changes
examples/crypto/README.md Outdated Show resolved Hide resolved
.github/workflows/validate-examples.yml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
examples/crypto/README.md Outdated Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
examples/crypto/main.rs Show resolved Hide resolved
@mikeee
fix: update crypto example
e3bbf92 
Signed-off-by: Mike Nguyen <[email protected]>
@mikeee
chore: re-order examples
b9fe764 
Signed-off-by: Mike Nguyen <[email protected]>
@mikeee
chore: re-order examples
52d853b 
Signed-off-by: Mike Nguyen <[email protected]>
mikeee
mikeee reviewed Mar 24, 2024
View reviewed changes
src/client.rs Outdated Show resolved Hide resolved
@zedgell zedgell requested a review from mikeee March 25, 2024 01:23
mikeee
mikeee reviewed Mar 25, 2024
View reviewed changes
Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last thing before merge 🎉

src/client.rs Outdated Show resolved Hide resolved
examples/crypto/main.rs Outdated Show resolved Hide resolved
examples/crypto/main.rs Outdated Show resolved Hide resolved
zedgell and others added 3 commits March 25, 2024 11:48
@zedgell @mikeee
Remove use dapr::dapr::dapr::proto::runtime::v1::{DecryptRequestOptio…
63c3f94 
…ns, EncryptRequestOptions};

Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Zachary K Edgell <[email protected]>
@zedgell @mikeee
Make types public
b731100 
Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Zachary K Edgell <[email protected]>
@zedgell @mikeee
Update examples/crypto/main.rs
fb1d6b3 
Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Zachary K Edgell <[email protected]>
mikeee
mikeee reviewed Mar 25, 2024
View reviewed changes
examples/crypto/main.rs Outdated Show resolved Hide resolved
examples/crypto/main.rs Outdated Show resolved Hide resolved
zedgell and others added 2 commits March 25, 2024 13:59
@zedgell @mikeee
Update main.rs
034da1d 
Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Zachary K Edgell <[email protected]>
@zedgell @mikeee
Update main.rs
02dd850 
Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Zachary K Edgell <[email protected]>
mikeee
mikeee approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to have consistency among the SDKs - this means an implementation with a stream returned, but this is a great first implementation 🎉

@mikeee mikeee merged commit ac71bb7 into dapr:main Mar 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeee mikeee mikeee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Cryptography API
2 participants
@zedgell @mikeee