Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement example validation #119

Merged
merged 19 commits into from
Mar 19, 2024
Merged

Implement example validation #119

merged 19 commits into from
Mar 19, 2024

Conversation

mikeee
Copy link
Member

@mikeee mikeee commented Feb 12, 2024

This PR creates an action workflow that is to validate the examples similar to that recently pushed to the go-sdk repo.

  • Each example will run in a parallel job
  • Mechanical Markdown is the basis for validating the expected output

TODOs / Follow up issue creations:

  • A non-default resiliency policy is required for the grpc servers to register successfully.
  • Speed up runs with caching

@mikeee mikeee marked this pull request as ready for review February 22, 2024 15:34
@mikeee
Copy link
Member Author

mikeee commented Feb 22, 2024

@yaron2 Please could I steal a moment of your time when possible to review with a goal of merging this, it assists with validation going forward.

@yaron2
Copy link
Member

yaron2 commented Feb 22, 2024

@yaron2 Please could I steal a moment of your time when possible to review with a goal of merging this, it assists with validation going forward.

Great PR! I'll carve out time for this

@mikeee mikeee requested review from a team as code owners March 19, 2024 17:52
@mikeee mikeee self-assigned this Mar 19, 2024
@mikeee mikeee merged commit aa10558 into dapr:main Mar 19, 2024
11 checks passed
@mikeee mikeee deleted the validation-workflow branch March 19, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants