-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle metadata for get_configuration and subscribe_configuration #118
Conversation
Signed-off-by: David Blackwood <[email protected]>
Signed-off-by: David Blackwood <[email protected]>
Cargo.toml
Outdated
@@ -1,6 +1,6 @@ | |||
[package] | |||
name = "dapr" | |||
version = "0.14.0" | |||
version = "0.14.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I understand the release process follows the one from the main repo, so I don't think we should upgrade it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. I wasn't sure what the version management rules were. I can revert this change to the version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh I'm learning as well. I suppose that's how it works even if I saw @danielgerlag's PR changing it. I would say we don't know in which version it will go so a PR shouldn't change it, especially you could have x PRs in parallel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can accept this for the upcoming release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cscetbon please revert to 0.14.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cscetbon please revert to 0.14.0
Not mine though 😬
This reverts commit 7747075. Signed-off-by: David Blackwood <[email protected]>
acbdc30
to
10be1ea
Compare
This reverts commit 7747075. Signed-off-by: David Blackwood <[email protected]>
This PR would address #117
Adds a
metadata
parameter to the client's existingget_configuration
andsubscribe_configuration
implementations. The newmetadata
parameter matches existing function signatures (fromget_state
, for example).Callers would need to include optional metadata: