Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle metadata for get_configuration and subscribe_configuration #118

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

blackwood-ra
Copy link
Contributor

This PR would address #117

Adds a metadata parameter to the client's existing get_configuration and subscribe_configuration implementations. The new metadata parameter matches existing function signatures (from get_state, for example).

Callers would need to include optional metadata:

let mut stream = client
  .subscribe_configuration(CONFIGSTORE_NAME, vec![(&key)], None)
  .await?;

@blackwood-ra blackwood-ra marked this pull request as ready for review February 8, 2024 19:42
Cargo.toml Outdated
@@ -1,6 +1,6 @@
[package]
name = "dapr"
version = "0.14.0"
version = "0.14.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand the release process follows the one from the main repo, so I don't think we should upgrade it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I wasn't sure what the version management rules were. I can revert this change to the version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh I'm learning as well. I suppose that's how it works even if I saw @danielgerlag's PR changing it. I would say we don't know in which version it will go so a PR shouldn't change it, especially you could have x PRs in parallel.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can accept this for the upcoming release

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cscetbon please revert to 0.14.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaron2 @cscetbon Reverted to 0.14.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cscetbon please revert to 0.14.0

Not mine though 😬

This reverts commit 7747075.

Signed-off-by: David Blackwood <[email protected]>
This reverts commit 7747075.

Signed-off-by: David Blackwood <[email protected]>
@yaron2 yaron2 merged commit a9df2d9 into dapr:master Feb 20, 2024
5 checks passed
@mikeee mikeee linked an issue Mar 20, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for Configuration API
3 participants