-
Notifications
You must be signed in to change notification settings - Fork 138
Added async workflow client implementation, leveraging new durabletask.aio.client implementation #861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…k.aio.client implementation Signed-off-by: Patrick Assuied <[email protected]>
d32c9aa to
d17b262
Compare
Signed-off-by: Patrick Assuied <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #861 +/- ##
==========================================
+ Coverage 86.63% 87.49% +0.86%
==========================================
Files 84 98 +14
Lines 4473 6484 +2011
==========================================
+ Hits 3875 5673 +1798
- Misses 598 811 +213 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@passuied I think this other PR covers this same thing, and is a bit more complete because it also have async context, but it's WIP as it has lots of lint changes that are now applied to |
|
@acroca actually this is a bit different, as this tackles the client initiating actions against a workflow(schedule workflow, signal events), instead of the internals of the workflow that my PR tackles. He did the PR in durabletask that complements this dapr/durabletask-python#17. The PRs his/mine are complementary and not overlapping |
acroca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I'd follow the same pattern as the DaprClient and not have a suffix Async for the async version.
ext/dapr-ext-workflow/dapr/ext/workflow/aio/dapr_workflow_client.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Patrick Assuied <[email protected]>
|
@passuied Can you add an example to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but tests are failing, and copyright headers need to be fixed :)
ext/dapr-ext-workflow/dapr/ext/workflow/aio/workflow_runtime.py
Outdated
Show resolved
Hide resolved
ext/dapr-ext-workflow/dapr/ext/workflow/aio/workflow_runtime.py
Outdated
Show resolved
Hide resolved
ext/dapr-ext-workflow/dapr/ext/workflow/aio/dapr_workflow_client.py
Outdated
Show resolved
Hide resolved
ext/dapr-ext-workflow/dapr/ext/workflow/aio/workflow_runtime.py
Outdated
Show resolved
Hide resolved
75f3e7c to
6b8d7c8
Compare
Signed-off-by: Patrick Assuied <[email protected]>
Signed-off-by: Patrick Assuied <[email protected]>
Description
Added async workflow client implementation, leveraging new durabletask.aio.client implementation
Issue reference
#834
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: