-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change word length due to error on mechanical-markdown #1279
Conversation
0c17158
to
3e54d98
Compare
@mcruzdev looking at the code changes.. I am confused on how this fixes the flaky test.. I remember seeing a comment somewhere where it was explained.. but I cannot find it now. |
Ok found it.. #1266 (comment) I still don't understand how changing the word count fixes the issue. @mcruzdev maybe you can share the sequence of things that happened and what are the expected values to make it easier to review. |
Ok for context, we are looking at the execution of this test: https://github.com/dapr/java-sdk/blob/3e54d98cf056162dc3bc237f337a359bffa8be18/examples/src/main/java/io/dapr/examples/workflows/README.md#fan-outfan-in-pattern This test executes five activities in parallel. Each activity counts the words (tokens), and then the workflow sums up all the results. The issue seems to be here:
Ok.. so changing the word count makes sense because of this: dapr/mechanical-markdown#37 |
Ok.. now I think I understand the full context.. I would recommend to change the output For example.. we can just add a period at the end and match with the period, for example: 'Activity returned: 2.' Those two will not clash when compared by mechanical markdown right? @mcruzdev Does this make sense? |
Yes, it makes sense 😅 |
a606832
to
c5ba0d6
Compare
Signed-off-by: Matheus Cruz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for looking into this!
Description
This pull request adjust the
mechanical-markdown
scenario due to an issue that lives onmechanical-markdown
lib.Closes #1266
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: