Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server-side warnings in the log when using Actors #585

Open
thewilli opened this issue Jun 28, 2024 · 0 comments · May be fixed by #586
Open

Server-side warnings in the log when using Actors #585

thewilli opened this issue Jun 28, 2024 · 0 comments · May be fixed by #586
Labels
bug Something isn't working

Comments

@thewilli
Copy link

Describe the bug

When using Actors, the server-side logs will always contain warnings about methods with invalid signatures, which is fine if it wasn't true for the required ones being part of ServerImplBaseCtx.

The messages are generated here and should imo not warn about required methods, as it just bloats the server logs.

To Reproduce

Expected behavior

The output matches the one listed in the README

Actual behavior

Server-side logs contain the following warnings:

== APP == method GetStateManager is illegal, err = the latest return type actor.StateManagerContext of method "GetStateManager" is not error, just skip it
== APP == method ID is illegal, err = the latest return type string of method "ID" is not error, just skip it
== APP == method SetID is illegal, err = num out invalid, just skip it
== APP == method SetStateManager is illegal, err = num out invalid, just skip it
== APP == method Type is illegal, err = the latest return type string of method "Type" is not error, just skip it
@thewilli thewilli added the bug Something isn't working label Jun 28, 2024
thewilli added a commit to thewilli/go-sdk that referenced this issue Jun 28, 2024
When checking for valid Actor methods, the SDK no longer emits warnings about invalid or inappropriate method signatures for the ones needed to be implemented for each Actor type.

Fixes dapr#585

Signed-off-by: Willi Eggeling <[email protected]>
@thewilli thewilli linked a pull request Jun 28, 2024 that will close this issue
3 tasks
thewilli added a commit to thewilli/go-sdk that referenced this issue Jul 8, 2024
When checking for valid Actor methods, the SDK no longer emits warnings about invalid or inappropriate method signatures for the ones needed to be implemented for each Actor type.

Fixes dapr#585

Signed-off-by: Willi Eggeling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant