Add support for Bulk State, i.e. SaveBulkStateAsync(...) method#962
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #962 +/- ##
==========================================
+ Coverage 69.80% 69.90% +0.10%
==========================================
Files 156 157 +1
Lines 5186 5224 +38
Branches 555 562 +7
==========================================
+ Hits 3620 3652 +32
- Misses 1434 1439 +5
- Partials 132 133 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Author
|
|
halspang
requested changes
Oct 3, 2022
Contributor
halspang
left a comment
halspang
left a comment
There was a problem hiding this comment.
Code itself is fine, but I think we should align more with the existing API. Shouldn't be a big change to switch it over.
yash-nisar
force-pushed
the
master
branch
3 times, most recently
from
eb4670e to
3681e10
Compare
halspang
reviewed
Oct 24, 2022
Contributor
halspang
left a comment
halspang
left a comment
There was a problem hiding this comment.
Just a nit-pick for some formatting.
Closes dapr#785 Signed-off-by: Yash Nisar <yashnisar@microsoft.com>
halspang
requested changes
Oct 25, 2022
Contributor
halspang
left a comment
halspang
left a comment
There was a problem hiding this comment.
Just some nits for the example now. Big thing you need is to add a reference to it in the README.
Closes dapr#963 Signed-off-by: Yash Nisar <yashnisar@microsoft.com>
halspang
approved these changes
Oct 31, 2022
4 tasks
This was referenced Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #785
Signed-off-by: Yash Nisar yashnisar@microsoft.com
Description
Add support for Bulk State, i.e. sending multiple key value pairs to the dapr
SaveState(...)APIIssue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #785
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: