Skip to content

Remove debug statement from configuration example#949

Merged
halspang merged 4 commits into
dapr:masterfrom
halspang:config_debug_statement
Jan 23, 2023
Merged

Remove debug statement from configuration example#949
halspang merged 4 commits into
dapr:masterfrom
halspang:config_debug_statement

Conversation

@halspang
Copy link
Copy Markdown
Contributor

Description

There was a debugging statement left in the configuration example. This commit removes it.

Signed-off-by: Hal Spang halspang@microsoft.com

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: Chore

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Hal Spang <halspang@microsoft.com>
@halspang halspang requested review from a team as code owners September 13, 2022 22:18
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 13, 2022

Codecov Report

Merging #949 (4ef69b3) into master (b8766b9) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #949      +/-   ##
==========================================
- Coverage   69.92%   69.90%   -0.02%     
==========================================
  Files         157      157              
  Lines        5227     5227              
  Branches      562      562              
==========================================
- Hits         3655     3654       -1     
- Misses       1439     1440       +1     
  Partials      133      133              
Flag Coverage Δ
net5 69.86% <ø> (-0.02%) ⬇️
net6 69.82% <ø> (ø)
netcoreapp3.1 69.86% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Dapr.Client/DaprClientGrpc.cs 86.73% <0.00%> (-0.15%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yash-nisar
Copy link
Copy Markdown
Contributor

Looks good to me !

@yash-nisar
Copy link
Copy Markdown
Contributor

@halspang Can this be merged ?

@halspang halspang requested review from a team and removed request for a team January 17, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants