Skip to content

Conversation

@saber-wang
Copy link
Contributor

@saber-wang saber-wang commented Sep 13, 2022

Description

@halspang In order to handle conflicts and use grpc, I opened a new merge request.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #883

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@saber-wang saber-wang requested review from a team as code owners September 13, 2022 06:04
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #947 (be3029e) into master (37ed498) will increase coverage by 0.30%.
The diff coverage is 100.00%.

❗ Current head be3029e differs from pull request most recent head f8b98ef. Consider uploading reports for the commit f8b98ef to get more accurate results

@@            Coverage Diff             @@
##           master     #947      +/-   ##
==========================================
+ Coverage   69.49%   69.79%   +0.30%     
==========================================
  Files         155      156       +1     
  Lines        5130     5181      +51     
  Branches      554      554              
==========================================
+ Hits         3565     3616      +51     
  Misses       1434     1434              
  Partials      131      131              
Flag Coverage Δ
net5 69.73% <100.00%> (+0.28%) ⬆️
net6 69.69% <100.00%> (+0.30%) ⬆️
netcoreapp3.1 69.75% <100.00%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Dapr.Client/DaprClient.cs 93.61% <ø> (ø)
src/Dapr.Client/DaprClientGrpc.cs 87.19% <100.00%> (+0.46%) ⬆️
src/Dapr.Client/DaprMetadata.cs 100.00% <100.00%> (ø)
src/Dapr.Client/ConfigurationItem.cs 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@halspang halspang merged commit 01cdc89 into dapr:master Sep 23, 2022
addjuarez pushed a commit to addjuarez/dotnet-sdk that referenced this pull request Sep 26, 2022
* feat: add metadata api
Signed-off-by: saberwang <[email protected]>

* Using HTTP API to get and set dapr metadata
Signed-off-by: saberwang <[email protected]>

* style
Signed-off-by: saberwang <[email protected]>

* using grpc to add metadata api
Signed-off-by: saberwang <[email protected]>

* style
Signed-off-by: saberwang <[email protected]>

Co-authored-by: halspang <[email protected]>
Signed-off-by: addjuarez <[email protected]>
@BartNetJS
Copy link

BartNetJS commented Feb 28, 2023

I'm testing the meta data implementation.
Is it also possible to get the url from an http binding:

apiVersion: dapr.io/v1alpha1
kind: Component
metadata:
name: myservice
namespace: mynamespace
spec:
type: bindings.http
version: v1
metadata:
- name: url
value: http://some-url:8090

@saber-wang
Copy link
Contributor Author

@BartNetJS
This information cannot be obtained. The api can refer to this document https://docs.dapr.io/reference/api/metadata_api/.

You can also propose this function in dapr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide a support for Dapr sidecar Metadata API

3 participants