Configuration API changes to support dictionary type response#943
Merged
Conversation
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## master #943 +/- ##
==========================================
- Coverage 69.51% 69.49% -0.03%
==========================================
Files 155 155
Lines 5134 5130 -4
Branches 554 554
==========================================
- Hits 3569 3565 -4
Misses 1434 1434
Partials 131 131
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
halspang
requested changes
Sep 12, 2022
Contributor
halspang
left a comment
halspang
left a comment
There was a problem hiding this comment.
Minor changes, overall looks good.
Signed-off-by: Amulya Varote <amulyavarote@microsoft.com>
amulyavarote
force-pushed
the
config_api_changes
branch
from
94dbbd7 to
92ca166
Compare
halspang
approved these changes
Sep 13, 2022
This was referenced Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you've made
Configuration API changes to support dictionary type response. The changes are added to both get configuration and subscribe configuration features.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #884
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: