Skip to content

Support PubSub DeadLetterTopic in topic attribute#916

Closed
xTriad wants to merge 1 commit into
dapr:masterfrom
xTriad:dead_letter_topic
Closed

Support PubSub DeadLetterTopic in topic attribute#916
xTriad wants to merge 1 commit into
dapr:masterfrom
xTriad:dead_letter_topic

Conversation

@xTriad
Copy link
Copy Markdown

@xTriad xTriad commented Jul 29, 2022

Description

We need the ability to define the PubSub Dead Letter Topic name in the C# "Topic" Attribute. I have not yet implemented tests as I am curious if I am on the right track with this pull request.

image

This returns the dead letter topic name in the /dapr/subscribe endpoint.

image

Issue reference

N/A

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests (Holding off until receiving further direction)
  • Extended the documentation (Holding off until receiving further direction)

@xTriad xTriad requested review from a team as code owners July 29, 2022 20:44
@xTriad xTriad marked this pull request as draft August 1, 2022 14:22
@halspang
Copy link
Copy Markdown
Contributor

It looks like this ended up having some duplicate work on it. Given this one is a draft, I'm going to favor the other one. Sorry for any lost work here @xTriad.

#929

@halspang halspang closed this Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants