Skip to content

Fix the problem of determining whether there is a MetadataSeparator error#900

Merged
halspang merged 16 commits into
dapr:masterfrom
saber-wang:master
Jul 20, 2022
Merged

Fix the problem of determining whether there is a MetadataSeparator error#900
halspang merged 16 commits into
dapr:masterfrom
saber-wang:master

Conversation

@saber-wang
Copy link
Copy Markdown
Contributor

@saber-wang saber-wang commented Jun 30, 2022

Description

I forgot a merge request when I deleted the branch yesterday😂😂

Judge logic error here and TopicAttribute.Metadataseparator default should be null

var metadataSeparator = e.FirstOrDefault(e => string.IsNullOrEmpty(e.MetadataSeparator)).MetadataSeparator ?? ",";

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #901

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

saber-wang and others added 15 commits May 19, 2022 16:28
Signed-off-by: saberwang <saberwang@hotmail.com>
Signed-off-by: saberwang <saberwang@hotmail.com>
Signed-off-by: saberwang <saberwang@hotmail.com>
Signed-off-by: saberwang <saberwang@hotmail.com>
Signed-off-by: saberwang <saberwang@hotmail.com>
Signed-off-by: saberwang <saberwang@hotmail.com>
Signed-off-by: saberwang <saberwang@hotmail.com>
Signed-off-by: saberwang <saberwang@hotmail.com>
Signed-off-by: saberwang <saberwang@hotmail.com>
Signed-off-by: saberwang <saberwang@hotmail.com>
@saber-wang saber-wang requested review from a team as code owners June 30, 2022 01:03
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 30, 2022

Codecov Report

Merging #900 (e26a9bf) into master (d061164) will not change coverage.
The diff coverage is 80.00%.

@@           Coverage Diff           @@
##           master     #900   +/-   ##
=======================================
  Coverage   70.11%   70.11%           
=======================================
  Files         152      152           
  Lines        4939     4939           
  Branches      543      543           
=======================================
  Hits         3463     3463           
  Misses       1349     1349           
  Partials      127      127           
Flag Coverage Δ
net5 70.07% <80.00%> (ø)
net6 70.01% <80.00%> (ø)
netcoreapp3.1 70.05% <80.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Dapr.AspNetCore/TopicAttribute.cs 77.77% <75.00%> (ø)
...r.AspNetCore/DaprEndpointRouteBuilderExtensions.cs 92.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d061164...e26a9bf. Read the comment docs.

Copy link
Copy Markdown
Contributor

@halspang halspang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment asking for an additional test case.

Comment thread test/Dapr.AspNetCore.IntegrationTest/SubscribeEndpointTest.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix the problem of determining whether there is a MetadataSeparator error

2 participants