Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Dapr.Testcontainers/Harnesses/BaseHarness.cs
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ public abstract class BaseHarness : IAsyncContainerFixture
/// <summary>
/// The HTTP port used by the Daprd container.
/// </summary>
public int DaprHttpPort => _daprd?.HttpPort ?? _daprHttpPortOverride ?? 0;
public int DaprHttpPort => _daprHttpPortOverride ?? _daprd?.HttpPort ?? 0;
/// <summary>
/// The gRPC port used by the Daprd container.
/// </summary>
public int DaprGrpcPort => _daprd?.GrpcPort ?? _daprGrpcPortOverride ?? 0;
public int DaprGrpcPort => _daprGrpcPortOverride ?? _daprd?.GrpcPort ?? 0;

private readonly string componentsDirectory;
private readonly Func<int, Task>? startApp;
Expand Down
3 changes: 2 additions & 1 deletion src/Dapr.Workflow/Client/WorkflowGrpcClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,8 @@ public override ValueTask DisposeAsync()
}

private CallOptions CreateCallOptions(CancellationToken cancellationToken) =>
DaprClientUtilities.ConfigureGrpcCallOptions(typeof(DaprWorkflowClient).Assembly, daprApiToken, cancellationToken);
DaprClientUtilities.ConfigureGrpcCallOptions(typeof(DaprWorkflowClient).Assembly, daprApiToken, cancellationToken)
.WithWaitForReady();

private static readonly TimeSpan MinWaitRetryDelay = TimeSpan.FromMilliseconds(50);
private static readonly TimeSpan MaxWaitRetryDelay = TimeSpan.FromSeconds(15);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@ public async Task AppStartsFirst_ShouldPreconfigurePorts()

Assert.True(harness.DaprHttpPort > 0);
Assert.True(harness.DaprGrpcPort > 0);

harness.SetPorts(3501, 50002);

Assert.Equal(3501, harness.DaprHttpPort);
Assert.Equal(50002, harness.DaprGrpcPort);
}

[Fact]
Expand Down Expand Up @@ -62,7 +67,7 @@ public void ResourcesStartFirst_ShouldNotPreconfigurePorts()

Assert.Equal(0, harness.DaprHttpPort);
}

// Concrete implementation for testing BaseHarness
private class TestHarness : BaseHarness
{
Expand Down
8 changes: 7 additions & 1 deletion test/Dapr.Workflow.Test/Client/WorkflowGrpcClientTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,16 @@ public async Task ScheduleNewWorkflowAsync_ShouldUseProvidedInstanceId_WhenOptio
var serializer = new StubSerializer { SerializeResult = "{\"x\":1}" };

CreateInstanceRequest? capturedRequest = null;
CallOptions? capturedCallOptions = null;

var grpcClientMock = CreateGrpcClientMock();
grpcClientMock
.Setup(x => x.StartInstanceAsync(It.IsAny<CreateInstanceRequest>(), It.IsAny<CallOptions>()))
.Callback<CreateInstanceRequest, CallOptions>((r, _) => capturedRequest = r)
.Callback<CreateInstanceRequest, CallOptions>((r, options) =>
{
capturedRequest = r;
capturedCallOptions = options;
})
.Returns(CreateAsyncUnaryCall(new CreateInstanceResponse { InstanceId = "id-from-sidecar" }));

var client = new WorkflowGrpcClient(grpcClientMock.Object, NullLogger<WorkflowGrpcClient>.Instance, serializer);
Expand All @@ -46,6 +51,7 @@ public async Task ScheduleNewWorkflowAsync_ShouldUseProvidedInstanceId_WhenOptio
Assert.Equal("instance-123", capturedRequest!.InstanceId);
Assert.Equal("MyWorkflow", capturedRequest.Name);
Assert.Equal("{\"x\":1}", capturedRequest.Input);
Assert.True(capturedCallOptions?.IsWaitForReady);
}

[Fact]
Expand Down
Loading