Skip to content

No longer swallows exceptions for anything except NotFound error when retrieving workflow state from runtime - #1877

Merged
WhitWaldo merged 1 commit into
masterfrom
workflow-state-bugfix
Jul 20, 2026
Merged

No longer swallows exceptions for anything except NotFound error when retrieving workflow state from runtime#1877
WhitWaldo merged 1 commit into
masterfrom
workflow-state-bugfix

Conversation

@WhitWaldo

Copy link
Copy Markdown
Contributor

Description

Only returning a response for GetWorkflowStatus if the metadata is returned for the workflow or the runtime returns a NotFound. Otherwise, the SDK no longer swallows the exception and instead passes it to the user to deal with.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1876

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

…returned for the workflow or the runtime returns a `NotFound`. Otherwise, the SDK no longer swallows the exception and instead passes it to the user to deal with.

Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
@WhitWaldo WhitWaldo added this to the v1.19 milestone Jul 20, 2026
@WhitWaldo WhitWaldo self-assigned this Jul 20, 2026
@WhitWaldo
WhitWaldo requested review from a team as code owners July 20, 2026 09:50
@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.16%. Comparing base (880ac05) to head (b24aeb5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1877   +/-   ##
=======================================
  Coverage   62.16%   62.16%           
=======================================
  Files         334      334           
  Lines        9727     9727           
  Branches     1133     1133           
=======================================
  Hits         6047     6047           
- Misses       3362     3363    +1     
+ Partials      318      317    -1     
Flag Coverage Δ
net10.0 62.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

1 participant