fix(workflow): add missing FailureDetails property to proto converter#1831
Merged
WhitWaldo merged 2 commits intoMay 27, 2026
Merged
Conversation
Signed-off-by: Matthias Eck <matthias.eck@zeiss.com>
WhitWaldo
approved these changes
May 26, 2026
WhitWaldo
left a comment
WhitWaldo
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me - thank you for taking the time to file the issue and put this PR together.
Contributor
|
@holopin-bot @Eckii24 sdk-badge Thank you! Here's a digital badge as a small token of appreciation. |
|
Congratulations @Eckii24, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cmqbf5zof0006jy0441n740oc This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
This was referenced Jun 12, 2026
This was referenced Jun 29, 2026
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you've made
Adds the missing mapping of
FailureDetailsinProtoConverters.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1830
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: