fix: ContinueAsNew integration tests#1784
Closed
Copilot wants to merge 2 commits intocopilot/investigate-integration-tests-failurefrom
Closed
fix: ContinueAsNew integration tests#1784Copilot wants to merge 2 commits intocopilot/investigate-integration-tests-failurefrom
Copilot wants to merge 2 commits intocopilot/investigate-integration-tests-failurefrom
Conversation
3 tasks
Co-authored-by: WhitWaldo <2238529+WhitWaldo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix: Skip 1.17-only workflow tests on Dapr < 1.17
fix: skip 1.17-only workflow tests on Dapr < 1.17
Apr 13, 2026
WhitWaldo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Integration tests using Dapr 1.17-only APIs (
context.IsPatched(),ListInstanceIdsAsync,GetInstanceHistoryAsync) were running unconditionally on older runtimes, causing them to hang indefinitely rather than skip.Changes:
WorkflowRpcTests— replaced try/catch/Assert.Skippattern with[MinimumDaprRuntimeFact("1.17.0")]onListInstanceIds_ShouldReturnScheduledWorkflowInstancesandGetInstanceHistory_ShouldReturnHistoryForCompletedWorkflowCombinedVersioningIntegrationTests— gatedShouldCombinePatchAndNameBasedVersioningwith[MinimumDaprRuntimeFact("1.17")]; without this, the patched workflow never reaches a terminal state on 1.16.x, hanging the test runnerWorkflowGrpcClient.IsRpcMethodNotSupportedByRuntime— tightened detection to require both"required metadata"and"dapr-app-id"in the error detail, preventing false-positive unsupported-RPC classificationsIssue reference
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: