Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/Actor/DemoActor.Interfaces/IDemoActor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public interface IDemoActor : IActor
/// <summary>
/// Method to save data.
/// </summary>
/// <param name="data">DAta to save.</param>
/// <param name="data">Data to save.</param>
/// <param name="ttl">TTL of state key.</param>
/// <returns>A task that represents the asynchronous save operation.</returns>
Task SaveData(MyData data, TimeSpan ttl);
Expand Down
12 changes: 6 additions & 6 deletions src/Dapr.Actors/Communication/ActorRequestMessageBody.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// ------------------------------------------------------------------------
// ------------------------------------------------------------------------
// Copyright 2021 The Dapr Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -28,13 +28,13 @@ public ActorRequestMessageBody(int parameterInfos)
this.parameters = new Dictionary<string, object>(parameterInfos);
}

public void SetParameter(int position, string paramName, object parameter)
public void SetParameter(int position, string parameterName, object parameter)
{
this.parameters[paramName] = parameter;
this.parameters[parameterName] = parameter;
}

public object GetParameter(int position, string paramName, Type paramType)
public object GetParameter(int position, string parameterName, Type paramType)
{
return this.parameters[paramName];
return this.parameters[parameterName];
}
}
}
14 changes: 7 additions & 7 deletions src/Dapr.Actors/Communication/IActorRequestMessageBody.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// ------------------------------------------------------------------------
// ------------------------------------------------------------------------
// Copyright 2021 The Dapr Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand All @@ -25,16 +25,16 @@ public interface IActorRequestMessageBody
/// This Api gets called to set remoting method parameters before serializing/dispatching the request.
/// </summary>
/// <param name="position">Position of the parameter in Remoting Method.</param>
/// <param name="parameName">Parameter Name in the Remoting Method.</param>
/// <param name="parameterName">Parameter Name in the Remoting Method.</param>
/// <param name="parameter">Parameter Value.</param>
void SetParameter(int position, string parameName, object parameter);
void SetParameter(int position, string parameterName, object parameter);

/// <summary>
/// This is used to retrive parameter from request body before dispatching to service remoting method.
/// This is used to retrieve parameter from request body before dispatching to service remoting method.
/// </summary>
/// <param name="position">Position of the parameter in Remoting Method.</param>
/// <param name="parameName">Parameter Name in the Remoting Method.</param>
/// <param name="parameterName">Parameter Name in the Remoting Method.</param>
/// <param name="paramType">Parameter Type.</param>
/// <returns>The parameter that is at the specified position and has the specified name.</returns>
object GetParameter(int position, string parameName, Type paramType);
}
object GetParameter(int position, string parameterName, Type paramType);
}
6 changes: 3 additions & 3 deletions src/Dapr.Client/BindingResponse.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// ------------------------------------------------------------------------
// ------------------------------------------------------------------------
// Copyright 2021 The Dapr Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand All @@ -20,13 +20,13 @@ namespace Dapr.Client;
/// <summary>
/// Represents the response from invoking a binding.
/// </summary>
/// <param name="request">The <see cref="BindingRequest" /> assocated with this response.</param>
/// <param name="request">The <see cref="BindingRequest" /> associated with this response.</param>
/// <param name="data">The response payload.</param>
/// <param name="metadata">The response metadata.</param>
public sealed class BindingResponse(BindingRequest request, ReadOnlyMemory<byte> data, IReadOnlyDictionary<string, string> metadata)
{
/// <summary>
/// Gets the <see cref="BindingRequest" /> assocated with this response.
/// Gets the <see cref="BindingRequest" /> associated with this response.
/// </summary>
public BindingRequest Request { get; } = request ?? throw new ArgumentNullException(nameof(request));

Expand Down
8 changes: 4 additions & 4 deletions test/Dapr.AspNetCore.IntegrationTest.App/DaprController.cs
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,11 @@ public void TopicMetadataSeparator()
{
}

[Topic("pubsub", "metadataseparatorbyemptytring")]
[HttpPost("/topicmetadataseparatorattrbyemptytring")]
[Topic("pubsub", "metadataseparatorbyemptystring")]
[HttpPost("/topicmetadataseparatorattrbyemptystring")]
[TopicMetadata("n1", "v1")]
[TopicMetadata("n1", "")]
public void TopicMetadataSeparatorByemptytring ()
public void TopicMetadataSeparatorByemptyString ()
{
}

Expand Down Expand Up @@ -170,4 +170,4 @@ public ActionResult<UserInfo> RequiresApiToken(UserInfo user)
{
return user;
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ public async Task SubscribeEndpoint_ReportsTopics()
subscriptions.ShouldContain(("pubsub", "metadata.1", "multiMetadataTopicAttr", "true", string.Empty, "n1=v1", string.Empty,
"{\"enabled\":true,\"maxMessagesCount\":500,\"maxAwaitDurationMs\":2000}"));
subscriptions.ShouldContain(("pubsub", "splitMetadataTopicBuilder", "splitMetadataTopics", string.Empty, string.Empty, "n1=v1;n2=v1", string.Empty, String.Empty));
subscriptions.ShouldContain(("pubsub", "metadataseparatorbyemptytring", "topicmetadataseparatorattrbyemptytring", string.Empty, string.Empty, "n1=v1,", string.Empty, String.Empty));
subscriptions.ShouldContain(("pubsub", "metadataseparatorbyemptystring", "topicmetadataseparatorattrbyemptystring", string.Empty, string.Empty, "n1=v1,", string.Empty, String.Empty));
// Test priority route sorting
var eTopic = subscriptions.FindAll(e => e.Topic == "E");
eTopic.Count.ShouldBe(3);
Expand All @@ -140,4 +140,4 @@ public async Task SubscribeEndpoint_ReportsTopics()
}
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ namespace Dapr.E2E.Test.Actors.WeaklyTypedTesting;
#endif
public class ResponseBase
{
public string BasePropeprty { get; set; }
}
public string BaseProperty { get; set; }
}
2 changes: 1 addition & 1 deletion test/Dapr.E2E.Test.App/Actors/WeaklyTypedTestingActor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public Task<ResponseBase> GetPolymorphicResponse()
{
var response = new DerivedResponse
{
BasePropeprty = "Base property value",
BaseProperty = "Base property value",
DerivedProperty = "Derived property value"
};

Expand Down