Skip to content

Correct XML documentation of BulkSubscribeAttribute #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025
Merged

Correct XML documentation of BulkSubscribeAttribute #1568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/Dapr.AspNetCore/BulkSubscribeAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ public class BulkSubscribeAttribute : Attribute, IBulkSubscribeMetadata
/// <summary>
/// Initializes a new instance of the <see cref="BulkSubscribeAttribute" /> class.
/// </summary>
/// <param name="topicName">The name of topic.</param>
/// <param name="maxMessagesCount">The name of the pubsub component to use.</param>
/// <param name="maxAwaitDurationMs">The topic name.</param>
/// <param name="topicName">The name of the topic to be bulk subscribed.</param>
/// <param name="maxMessagesCount">Maximum number of messages in a bulk message from the broker.</param>
/// <param name="maxAwaitDurationMs">Maximum duration in milliseconds to wait for maxMessagesCount messages by the broker.</param>
public BulkSubscribeAttribute(string topicName, int maxMessagesCount, int maxAwaitDurationMs)
{
this.TopicName = topicName;
Expand All @@ -38,8 +38,8 @@ public BulkSubscribeAttribute(string topicName, int maxMessagesCount, int maxAwa
/// <summary>
/// Initializes a new instance of the <see cref="BulkSubscribeAttribute" /> class.
/// </summary>
/// <param name="topicName">The name of topic.</param>
/// <param name="maxMessagesCount">The name of the pubsub component to use.</param>
/// <param name="topicName">The name of the topic to be bulk subscribed.</param>
/// <param name="maxMessagesCount">Maximum number of messages in a bulk message from the broker.</param>
public BulkSubscribeAttribute(string topicName, int maxMessagesCount)
{
this.TopicName = topicName;
Expand All @@ -49,19 +49,19 @@ public BulkSubscribeAttribute(string topicName, int maxMessagesCount)
/// <summary>
/// Initializes a new instance of the <see cref="BulkSubscribeAttribute" /> class.
/// </summary>
/// <param name="topicName">The name of topic.</param>
/// <param name="topicName">The name of the topic to be bulk subscribed.</param>
public BulkSubscribeAttribute(string topicName)
{
this.TopicName = topicName;
}

/// <summary>
/// Maximum number of messages in a bulk message from the message bus.
/// Maximum number of messages in a bulk message from the broker.
/// </summary>
public int MaxMessagesCount { get; } = 100;

/// <summary>
/// Maximum duration to wait for maxBulkSubCount messages by the message bus
/// Maximum duration in milliseconds to wait for MaxMessagesCount messages by the broker
/// before sending the messages to Dapr.
/// </summary>
public int MaxAwaitDurationMs { get; } = 1000;
Expand Down
Loading