-
Notifications
You must be signed in to change notification settings - Fork 362
Replace [Obsolete] with [Experimental] attributes #1564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
…mplementations Signed-off-by: Whit Waldo <[email protected]>
…implementation Signed-off-by: Whit Waldo <[email protected]>
…o methods Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
…controller. Also fixed logging and switched to use of a primary constructor. Signed-off-by: Whit Waldo <[email protected]>
3 tasks
…tes in the example and test projects Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
…t in the code generator tests Signed-off-by: Whit Waldo <[email protected]>
WhitWaldo
added a commit
to WhitWaldo/dapr-dotnet-sdk
that referenced
this pull request
Aug 12, 2025
* Replaced Obsolete with Experimental attributes throughout solution, added documentation and updated unit tests
WhitWaldo
added a commit
to WhitWaldo/dapr-dotnet-sdk
that referenced
this pull request
Aug 13, 2025
* Replaced Obsolete with Experimental attributes throughout solution, added documentation and updated unit tests
WhitWaldo
added a commit
to WhitWaldo/dapr-dotnet-sdk
that referenced
this pull request
Aug 13, 2025
* Replaced Obsolete with Experimental attributes throughout solution, added documentation and updated unit tests
WhitWaldo
added a commit
to WhitWaldo/dapr-dotnet-sdk
that referenced
this pull request
Aug 13, 2025
* Replaced Obsolete with Experimental attributes throughout solution, added documentation and updated unit tests
WhitWaldo
added a commit
to WhitWaldo/dapr-dotnet-sdk
that referenced
this pull request
Aug 13, 2025
* Replaced Obsolete with Experimental attributes throughout solution, added documentation and updated unit tests Signed-off-by: Whit Waldo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are some places where it makes sense to mark things as [Obsolete], but it'd be nice to reserve that attribute only for those places where something is truly obsolete and not recommended as a path going forward. It's all we've had to date to mark non-stable functionality, but with the shift to .NET 8 as the minimal version, this brings with it two new attributes: [Experimental] and [RequiresPreviewFeatures].
The latter has more to do with C# language features, so we'll instead opt to use the
[Experimental]flag here with the identifier setup "DAPR_{block}" (e.g.DAPR_CONVERSATIONso that developers can easily suppress warnings about it with a common identifier across the whole of the block instead of having a separate number for every method within it as it's expected that whole types will be certified instead of individual methods.This issue is intended to replace the previous experimentation done at #1487
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1219
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: