Replace HashSet with ConcurrentDictionary in WorkflowLoggingService

[TomasEkeli]

This should help with issue #1273 - intermittent exceptions from WorkflowLoggingService.

There is no concurrent HashSet in .NET, so we use ConcurrentDictionary with a byte as the value to simulate a set. For this use-case we do not care if the Key already exists, so we can use TryAdd to add items without considering the return value.

Description

Replaces HashSet<string> as the collection that stores Activity and Workflow names for logging with ConcurrentDictionary<string, byte>

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1273

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

• Code compiles correctly
• Created/updated tests
• Extended the documentation

[WhitWaldo]

First of all, thank you for taking the time to spot this and submit a PR - I really appreciate it!

Could you please sign your commit? You can read more about DCO requirement here, but we'll need it in place before the PR can be merged.

[WhitWaldo]

Looks fine to me - good to go once the DCO is in place.

[TomasEkeli]

I have force-pushed with the requried string, but for some reason the DCO does not register it?

edit: I have check the documetation you linked, and it only seems to require adding a "Signed-off-by" -line to the commit. I did that yesterday through a force-push, but the DCO check is still red.

Does it have to be re-activated or something?

[WhitWaldo]

I have force-pushed with the requried string, but for some reason the DCO does not register it?

edit: I have check the documetation you linked, and it only seems to require adding a "Signed-off-by" -line to the commit. I did that yesterday through a force-push, but the DCO check is still red.

Does it have to be re-activated or something?

Looks like it's failing because the email address you're using in GitHub doesn't match the one you signed off with. If you can either add the other one to GitHub or change the DCO to match, we'll be square here.

[TomasEkeli]

Ah, I understand. I have many e-mail addresses, and I'm not 100% sure which github thinks I should use.

I'll force-push a new one with a likely address :)

[WhitWaldo]

Looks good to me!

[WhitWaldo]

Thank you very much for your contribution here!