Fixed unit tests validating actor reminder deserialization #1475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…runs a duplicate check instead by accident) Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
siri-varma
reviewed
Feb 26, 2025
| var defaultActorTimerManager = new DefaultActorTimerManager(interactor.Object); | ||
| var actorReminder = new ActorReminder(actorType, new ActorId(actorId), "remindername", new byte[] { }, TimeSpan.FromMinutes(1), TimeSpan.FromMinutes(1)); | ||
| var actualData = string.Empty; | ||
| var actorId = "123"; |
Contributor
There was a problem hiding this comment.
May be a nitpick, is the indentation off here ? I see variables placed directly under the bracket (line 29)
nvm
This was referenced Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While investigating #1464 , I discovered that there already existed several unit tests with one on point. While I'm unable to recreate the issue detailed, I did notice that there were a few improvements to make to the unit tests in this class, including:
GetReminderAsync_ReturnsResultWhenAvailabletest double checked thePeriodproperty instead of checking bothPeriodandDueTime.const stringwhere possible instead ofvar.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1464
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: