Update actor reminder example.#1179
Merged
Merged
Conversation
Signed-off-by: Phillip Hoff <phillip@orst.edu>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1179 +/- ##
=======================================
Coverage 66.42% 66.42%
=======================================
Files 171 171
Lines 5758 5758
Branches 626 626
=======================================
Hits 3825 3825
Misses 1784 1784
Partials 149 149
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
halspang
approved these changes
Nov 7, 2023
divzi-p
pushed a commit
to divzi-p/dotnet-sdk
that referenced
this pull request
Dec 10, 2024
Signed-off-by: Phillip Hoff <phillip@orst.edu> Co-authored-by: halspang <70976921+halspang@users.noreply.github.com> Signed-off-by: Divya Perumal <diperuma@microsoft.com>
This was referenced Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the actor reminder example to resolve an unexpected exception. The actor was attempting to directly return an
IActorReminderinstance but the underlying type was not intended to be used outside of the actor and was not designed to be serialized. Instead, its properties are now copied to a separate type which is returned to the caller. A couple of other changes were made to the client project to correct assumptions about return types.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1177
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: