[Workflow] Improve management API usability#1087
Conversation
Signed-off-by: Chris Gillum <cgillum@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## master #1087 +/- ##
==========================================
- Coverage 68.07% 67.51% -0.57%
==========================================
Files 169 170 +1
Lines 5604 5652 +48
Branches 592 600 +8
==========================================
+ Hits 3815 3816 +1
- Misses 1649 1696 +47
Partials 140 140
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
While you didn't touch the file, we should update the asserts inside WorkflowTest.cs to use the enumeration: "WorkflowRuntimeStatus" for the status of the runtime rather than hardcoded values such as "RUNNING", "SUSPENDED", etc. |
Oh, interesting. I've never used FluentAssertions before, but it seems like a weakness in its design. Ideally the compiler would have caught this. I'll go ahead and fix that, along with your other suggestions. |
Signed-off-by: Chris Gillum <cgillum@microsoft.com>
halspang
left a comment
There was a problem hiding this comment.
Mostly nitpicks, overall seems fine.
Signed-off-by: Chris Gillum <cgillum@microsoft.com>
* [Workflow] Improve management API usability Signed-off-by: Chris Gillum <cgillum@microsoft.com> * PR feedback and update E2E test Signed-off-by: Chris Gillum <cgillum@microsoft.com> * PR feedback Signed-off-by: Chris Gillum <cgillum@microsoft.com> --------- Signed-off-by: Chris Gillum <cgillum@microsoft.com> Signed-off-by: Erik O'Leary <erik.m.oleary@gmail.com>
Description
This PR contains breaking changes to the v1.10 workflow management client APIs. The point of these changes is to improve the usability of these core APIs. This includes adding a few additional convenience types and methods.
This PR also updates the console app sample, replacing the
DaprWorkflowClientwithDaprClient, which was always the intent.Issue reference
Resolves #1027.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
FYI @RyanLettieri