Skip to content

[docs] Update API calls in workflow example#1083

Merged
halspang merged 9 commits into
dapr:masterfrom
hhunter-ms:issue_1082
May 18, 2023
Merged

[docs] Update API calls in workflow example#1083
halspang merged 9 commits into
dapr:masterfrom
hhunter-ms:issue_1082

Conversation

@hhunter-ms
Copy link
Copy Markdown
Contributor

Description

Update API calls in the workflow example
Still need to add other examples? raise event/pause/resume?

Issue reference

This PR will close: #1082
Related issue: #1079

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

hhunter-ms added 3 commits May 2, 2023 13:16
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms hhunter-ms requested review from a team as code owners May 2, 2023 17:22
@codecov
Copy link
Copy Markdown

codecov Bot commented May 2, 2023

Codecov Report

Merging #1083 (8e2b8ff) into master (8152c74) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1083   +/-   ##
=======================================
  Coverage   67.49%   67.49%           
=======================================
  Files         170      170           
  Lines        5652     5652           
  Branches      600      600           
=======================================
  Hits         3815     3815           
  Misses       1697     1697           
  Partials      140      140           
Flag Coverage Δ
net6 67.42% <ø> (ø)
net7 67.42% <ø> (ø)
netcoreapp3.1 67.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@hhunter-ms
Copy link
Copy Markdown
Contributor Author

@RyanLettieri for visibility

@hhunter-ms
Copy link
Copy Markdown
Contributor Author

@cgillum @RyanLettieri could you take a look and let me know if there are any other updates that would apply to this doc? here's the current, live version of the doc: https://docs.dapr.io/developing-applications/sdks/dotnet/dotnet-workflow/dotnet-workflow-howto/

Comment thread daprdocs/content/en/dotnet-sdk-docs/dotnet-workflow/dotnet-workflow-howto.md Outdated
Comment thread daprdocs/content/en/dotnet-sdk-docs/dotnet-workflow/dotnet-workflow-howto.md Outdated
@cgillum
Copy link
Copy Markdown
Contributor

cgillum commented May 10, 2023

@hhunter-ms I opened a PR against your PR to address my own comments: hhunter-ms#1

Fix workflow inputs and outputs for v1.11
@hhunter-ms
Copy link
Copy Markdown
Contributor Author

@hhunter-ms I opened a PR against your PR to address my own comments: hhunter-ms#1

thanks Chris! @cgillum

Copy link
Copy Markdown
Contributor

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is ready to be merged. I don't currently anticipate any more changes needed for 1.11.

@hhunter-ms hhunter-ms changed the title [docs][WIP] Update API calls in workflow example [docs] Update API calls in workflow example May 17, 2023
@halspang halspang merged commit a2d3c3a into dapr:master May 18, 2023
onionhammer pushed a commit to onionhammer/dotnet-sdk that referenced this pull request May 30, 2023
* update calls in the example

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

* remove gitmodules

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

* remove daprdocs/themes/docsy

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

* fix links and add links

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

* Fix workflow inputs and outputs for v1.11

---------

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Co-authored-by: Chris Gillum <cgillum@gmail.com>
Signed-off-by: Erik O'Leary <erik.m.oleary@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs] Update API calls for workflow

3 participants