Move config api to stable#1077
Merged
Merged
Conversation
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1077 +/- ##
==========================================
- Coverage 68.95% 68.93% -0.02%
==========================================
Files 169 169
Lines 5534 5534
Branches 588 588
==========================================
- Hits 3816 3815 -1
- Misses 1578 1579 +1
Partials 140 140
Flags with carried forward coverage won't be shown. Click here to find out more.
|
32 tasks
shivamkm07
force-pushed
the
stable_configapi
branch
from
93adbfc to
db485a7
Compare
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Contributor
Author
|
@dapr/maintainers-dotnet-sdk @dapr/approvers-dotnet-sdk Pinging for reviews. |
Closed
halspang
reviewed
May 2, 2023
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
halspang
approved these changes
May 3, 2023
onionhammer
pushed a commit
to onionhammer/dotnet-sdk
that referenced
this pull request
May 30, 2023
* updating protos Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * updating config api to stable Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * workflow changes to fix build failure Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * updating go version Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> * go version from dapr/cli repo Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> --------- Signed-off-by: Shivam Kumar <shivamkm07@gmail.com> Signed-off-by: Erik O'Leary <erik.m.oleary@gmail.com>
This was referenced Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates config API to stable. It updates the protos to include the stable apis. There has been some workflow changes causing the build to fail with latest dapr protos. It also fixes it
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: