[docs] Add workflows to .NET client doc by hhunter-ms · Pull Request #1019 · dapr/dotnet-sdk

hhunter-ms · 2023-02-01T19:43:54Z

Signed-off-by: Hannah Hunter hannahhunter@microsoft.com

Description

Add example of workflow calling to .NET Client doc

Issue reference

PR will close: #1016

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Code compiles correctly
Created/updated tests
Extended the documentation

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

hhunter-ms · 2023-02-01T19:44:49Z

@cgillum @RyanLettieri @msfussell

codecov · 2023-02-01T19:46:55Z

Codecov Report

Merging #1019 (baf1a0b) into master (22ac4c5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1019   +/-   ##
=======================================
  Coverage   69.45%   69.45%           
=======================================
  Files         162      162           
  Lines        5432     5432           
  Branches      585      585           
=======================================
  Hits         3773     3773           
  Misses       1519     1519           
  Partials      140      140

Flag	Coverage Δ
net6	`69.38% <ø> (ø)`
net7	`69.38% <ø> (ø)`
netcoreapp3.1	`69.42% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

RyanLettieri · 2023-02-02T20:43:01Z

+```csharp
+var daprClient = new DaprClientBuilder().Build();
+
+// Start workflow


string instanceId;
string workflowComponentName;
string workflowName;
object input ;

It might be helpful to add all of these above "//Start workflow" to give the user a better idea as to what variable types everything is.

Don't bother with a CancellationToken cts local variable. Just pass CancellationToken.None directly as the last input of StartWorkflowAsync.

If we're using CancellationToken.None I'd rather just use the default variable. I worry that this implies that you have to use a CancellationToken instead of having it as optional.

Oh, good point. In that case, let’s remove both the options variable and the cancellation token.

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

…e_1016

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

…into issue_1016

halspang

Two small comments.

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

* add workflows to client page Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>

…ity. (#1020) * Workflow Management - Initial Methods (#1003) Initial work for workflows DotNET SDK Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Beefed up the workflows example program and added in statestore functionality Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Addressing a bunch of review comments Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Updates to readme and demo for workflows Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Changed webapp to console app Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Update DurableTask SDK dependency to get ARM64 compatibility (#1024) * Update DurableTask SDK dependency to get ARM64 compatibility Signed-off-by: Chris Gillum <cgillum@microsoft.com> * Fix issue with gRPC address override behavior Signed-off-by: Chris Gillum <cgillum@microsoft.com> Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Remove Web APIs and web dependencies Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Renaming WorkflowWebApp to WorkflowConsoleApp Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Various updates to the sample app - Replaced DaprClient with WorkflowEngineClient - Removed unused etag logic - Fixed incorrect usage of certain model types - Cleaned up logs and console output - Simplified program loop - Cleaned up console output and added some coloring - Added error handling in the console interactions - Various other tweaks/simplifications/enhancements Signed-off-by: Chris Gillum <cgillum@microsoft.com> Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Updates to README and demo http commands Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Make README copy/paste-able and some other minor tweaks Signed-off-by: Chris Gillum <cgillum@microsoft.com> Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Adding in Paul's devcontainer work Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * More README touch-ups Signed-off-by: Chris Gillum <cgillum@microsoft.com> Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * [docs] Add workflows to .NET client doc (#1019) * add workflows to client page Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Updating workflows readme and example Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Fixing README for letting users know which .NET is needed Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * moving using statements above the namespace Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> --------- Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> Signed-off-by: Chris Gillum <cgillum@microsoft.com> Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> Co-authored-by: Ryan Lettieri <ryanLettieri@microsoft.com> Co-authored-by: Chris Gillum <cgillum@microsoft.com> Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>

* add workflows to client page Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

…ity. (dapr#1020) * Workflow Management - Initial Methods (dapr#1003) Initial work for workflows DotNET SDK Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Beefed up the workflows example program and added in statestore functionality Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Addressing a bunch of review comments Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Updates to readme and demo for workflows Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Changed webapp to console app Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Update DurableTask SDK dependency to get ARM64 compatibility (dapr#1024) * Update DurableTask SDK dependency to get ARM64 compatibility Signed-off-by: Chris Gillum <cgillum@microsoft.com> * Fix issue with gRPC address override behavior Signed-off-by: Chris Gillum <cgillum@microsoft.com> Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Remove Web APIs and web dependencies Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Renaming WorkflowWebApp to WorkflowConsoleApp Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Various updates to the sample app - Replaced DaprClient with WorkflowEngineClient - Removed unused etag logic - Fixed incorrect usage of certain model types - Cleaned up logs and console output - Simplified program loop - Cleaned up console output and added some coloring - Added error handling in the console interactions - Various other tweaks/simplifications/enhancements Signed-off-by: Chris Gillum <cgillum@microsoft.com> Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Updates to README and demo http commands Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Make README copy/paste-able and some other minor tweaks Signed-off-by: Chris Gillum <cgillum@microsoft.com> Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Adding in Paul's devcontainer work Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * More README touch-ups Signed-off-by: Chris Gillum <cgillum@microsoft.com> Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * [docs] Add workflows to .NET client doc (dapr#1019) * add workflows to client page Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Updating workflows readme and example Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * Fixing README for letting users know which .NET is needed Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> * moving using statements above the namespace Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> --------- Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com> Signed-off-by: Chris Gillum <cgillum@microsoft.com> Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com> Co-authored-by: Ryan Lettieri <ryanLettieri@microsoft.com> Co-authored-by: Chris Gillum <cgillum@microsoft.com> Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>

add workflows to client page

2d52c00

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

hhunter-ms requested review from a team as code owners February 1, 2023 19:43

cgillum reviewed Feb 1, 2023

View reviewed changes

Comment thread daprdocs/content/en/dotnet-sdk-docs/dotnet-client/_index.md Outdated

update title per Chris

24b8450

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

RyanLettieri reviewed Feb 2, 2023

View reviewed changes

hhunter-ms and others added 2 commits February 2, 2023 16:09

update from Ryan

49cc32e

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

Merge branch 'master' into issue_1016

0c22791

RyanLettieri reviewed Feb 6, 2023

View reviewed changes

Comment thread daprdocs/content/en/dotnet-sdk-docs/dotnet-client/_index.md Outdated

hhunter-ms added 3 commits February 6, 2023 11:05

Merge branch 'master' of https://github.com/dapr/dotnet-sdk into issu…

8e23b8e

…e_1016

update per Ryan

dffa664

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

Merge branch 'issue_1016' of https://github.com/hhunter-ms/dotnet-sdk …

d6824ad

…into issue_1016

halspang reviewed Feb 7, 2023

View reviewed changes

Comment thread daprdocs/content/en/dotnet-sdk-docs/dotnet-client/_index.md Outdated

halspang reviewed Feb 7, 2023

View reviewed changes

remove workflow options and cts

dbf6f68

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

RyanLettieri reviewed Feb 7, 2023

View reviewed changes

Comment thread daprdocs/content/en/dotnet-sdk-docs/dotnet-client/_index.md Outdated

remove default

b6f8cbc

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

halspang previously approved these changes Feb 7, 2023

View reviewed changes

cgillum reviewed Feb 7, 2023

View reviewed changes

update per Chris; make consistent

dc1abfd

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

hhunter-ms dismissed halspang’s stale review via dc1abfd February 8, 2023 15:30

ope - forgot the input update

baf1a0b

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

cgillum approved these changes Feb 8, 2023

View reviewed changes

halspang approved these changes Feb 8, 2023

View reviewed changes

halspang merged commit bc3ec80 into dapr:master Feb 8, 2023

yash-nisar pushed a commit to yash-nisar/dotnet-sdk that referenced this pull request Feb 27, 2023

[docs] Add workflows to .NET client doc (dapr#1019)

1cde789

* add workflows to client page Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[docs] Add workflows to .NET client doc#1019

[docs] Add workflows to .NET client doc#1019
halspang merged 11 commits into
dapr:masterfrom
hhunter-ms:issue_1016

hhunter-ms commented Feb 1, 2023

Uh oh!

hhunter-ms commented Feb 1, 2023

Uh oh!

codecov Bot commented Feb 1, 2023 •

edited

Loading

Uh oh!

Uh oh!

RyanLettieri Feb 2, 2023 •

edited

Loading

Uh oh!

cgillum Feb 2, 2023

Uh oh!

halspang Feb 7, 2023

Uh oh!

cgillum Feb 7, 2023

Uh oh!

Uh oh!

Uh oh!

halspang left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

hhunter-ms commented Feb 1, 2023

Description

Issue reference

Checklist

Uh oh!

hhunter-ms commented Feb 1, 2023

Uh oh!

codecov Bot commented Feb 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

RyanLettieri Feb 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cgillum Feb 2, 2023

Choose a reason for hiding this comment

Uh oh!

halspang Feb 7, 2023

Choose a reason for hiding this comment

Uh oh!

cgillum Feb 7, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

halspang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Feb 1, 2023 •

edited

Loading

RyanLettieri Feb 2, 2023 •

edited

Loading