-
Notifications
You must be signed in to change notification settings - Fork 781
Multi-app workflows: improve docs and images #4878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Im running into issues running the hugo server locally even without my changes in this PR: |
|
Just figured it out - Had to prune all my local submodules and update them. got it :thumb |
|
I will need to resolve conflicts once this PR is merged Im updating |
msfussell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cicoyle Looking good. Left a few comments
daprdocs/content/en/developing-applications/building-blocks/workflow/howto-author-workflow.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/howto-author-workflow.md
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/workflow-multi-app.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/workflow-multi-app.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/workflow-multi-app.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/workflow-multi-app.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/workflow-multi-app.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/workflow-multi-app.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/workflow/workflow-multi-app.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
56f1063 to
44e2756
Compare
Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Cassie Coyle <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
|
@msfussell - all conflicts are resolved and feedback has been incorporated 👍🏻 |
|
@marcduiker - Is going to update the images with the dapr theme to be consistent |
|
@cicoyle can you update the PR with these images? |
Signed-off-by: Cassandra Coyle <[email protected]>
marcduiker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* add complex wf illustration and fix other image Signed-off-by: Cassandra Coyle <[email protected]> * cleanup Signed-off-by: Cassandra Coyle <[email protected]> * update howto author wfs Signed-off-by: Cassandra Coyle <[email protected]> * update go code to use vanity client Signed-off-by: Cassandra Coyle <[email protected]> * Apply suggestions from code review Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Cassie Coyle <[email protected]> * add scheduleworkflow note Signed-off-by: Cassandra Coyle <[email protected]> * update images Signed-off-by: Cassandra Coyle <[email protected]> --------- Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: Cassie Coyle <[email protected]> Co-authored-by: Mark Fussell <[email protected]> Co-authored-by: Marc Duiker <[email protected]>


Add complex scenario and explanation and fix other image to use 'child' instead of 'suborchestrator'.