-
Notifications
You must be signed in to change notification settings - Fork 781
Added 'How the Outbox Works' section and expand requirements with int… #4875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ernal topic details Signed-off-by: Bilgin Ibryam <[email protected]>
msfussell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed with comments
daprdocs/content/en/developing-applications/building-blocks/state-management/howto-outbox.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/state-management/howto-outbox.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/state-management/howto-outbox.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/state-management/howto-outbox.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/state-management/howto-outbox.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/state-management/howto-outbox.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/state-management/howto-outbox.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/state-management/howto-outbox.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep this file source code and make this consistent with styling, can you add a slide after slide 39 in this deck https://docs.google.com/presentation/d/1q70WNp4OEstpwgDhg7gXRAud2pu68RYAZrwQK9_sZGk/edit?slide=id.p39#slide=id.p39.
Also can you update the current diagram (which is slide 39) as part of this PR. @marcduiker can help here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I am trying to understand is, do the dotted lined represent transaction boundaries or not? If so I would say this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll redraw the diagram in Dapr style and label the transaction boundary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcduiker - Will you do that on a separate PR or on this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it has been replaced in this PR
daprdocs/content/en/developing-applications/building-blocks/state-management/howto-outbox.md
Show resolved
Hide resolved
…ate-management/howto-outbox.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Bilgin Ibryam <[email protected]>
…ate-management/howto-outbox.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Bilgin Ibryam <[email protected]>
…ate-management/howto-outbox.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Bilgin Ibryam <[email protected]>
…ate-management/howto-outbox.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Bilgin Ibryam <[email protected]>
…ate-management/howto-outbox.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Bilgin Ibryam <[email protected]>
…ate-management/howto-outbox.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Bilgin Ibryam <[email protected]>
…ate-management/howto-outbox.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Bilgin Ibryam <[email protected]>
…ate-management/howto-outbox.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Bilgin Ibryam <[email protected]>
Applied suggestions from the review manually. Signed-off-by: Bilgin Ibryam <[email protected]>
Signed-off-by: Bilgin Ibryam <[email protected]>
marcduiker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Issue reference
#4032