Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction to global ha configuration using yaml #2067

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

abelperezok
Copy link
Contributor

The global configuration to enable ha was not correct, it was in the same format as the command line, but it's a yaml file and it should be in a nested format.

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Issue reference

@abelperezok abelperezok requested review from a team as code owners December 29, 2021 12:26
@greenie-msft
Copy link
Collaborator

Hi @abelperezok. Thank you for your contribution. Can you please sign your commit so we can merge this PR? The DCO check is failing due to commits missing your signature.

Guidance for how to sign commits can be found here: https://docs.dapr.io/contributing/contributing-overview/#developer-certificate-of-origin-signing-your-work

The global configuration to enable ha was not correct, it was in the same format as the command line, but it's a yaml file and it should be in a nested format.

Signed-off-by: Abel Perez Martinez <[email protected]>
@abelperezok
Copy link
Contributor Author

Hi @greenie-msft I've corrected my commit with the sign-off option.

@greenie-msft greenie-msft merged commit 06c525f into dapr:v1.5 Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants