FIX Pulsar pubsub component initialization when using oauth2ClientSecretPath#4161
Merged
FIX Pulsar pubsub component initialization when using oauth2ClientSecretPath#4161
Conversation
atrauzzi
reviewed
Jan 13, 2026
atrauzzi
left a comment
There was a problem hiding this comment.
I feel like each supported format should be a separate field, for consistency and expectations. Also protects against the 🛸 future 🛸 in case we reach a point where there are too many scenarios to sort out?
atrauzzi
reviewed
Jan 13, 2026
Contributor
Author
Agreed - we should split the paths/functions - name: oauth2CredentialsFile
type: string
description: |
The path to a JSON file containing both client_id and client_secret.
example: "/path/to/oauth2/credentials.json" - name: oauth2ClientSecretPath
type: string
description: |
The path to a plain text file containing the OAuth Client Secret.
example: "/path/to/oauth2/client_secret.txt" |
…e supports Signed-off-by: MyMirelHub <15373565+MyMirelHub@users.noreply.github.com>
ddb7953 to
69ae0ba
Compare
…et files Signed-off-by: MyMirelHub <15373565+MyMirelHub@users.noreply.github.com>
JoshVanL
approved these changes
Jan 15, 2026
cicoyle
approved these changes
Jan 15, 2026
Contributor
|
Can you open a docs PR noting the metadata fields @MyMirelHub ? |
Contributor
|
Scratch that - docs PR is here |
This was referenced Jan 15, 2026
Merged
passuied
pushed a commit
to passuied/components-contrib
that referenced
this pull request
Feb 14, 2026
…retPath (dapr#4161) Signed-off-by: MyMirelHub <15373565+MyMirelHub@users.noreply.github.com> Co-authored-by: Josh van Leeuwen <me@joshvanl.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes
oauth2ClientSecretPath(which previously incorrectly looked for token instead of client secret), offloads file loading to common client credentials library, and introducesoauth2CredentialsFilefor loading client_id, client_secret, and issuer_url from a JSON file.oauth2ClientSecretPath: Fixed to load client secret from file (previously incorrectly looked for token)oauth2CredentialsFile: New field for loadingclient_id,client_secret, andissuer_urlfrom a JSON file{"client_id": "...", "client_secret": "...", "issuer_url": "..."}Implementation Details
common/authentication/oauth2packageLoadCredentialsFromJSONFilefunction for parsing JSON credential filesIssue reference
#4162
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: