-
Notifications
You must be signed in to change notification settings - Fork 542
Adds Global TTL Configuration for DynamoDB State Store #4055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ZeynelKoca
wants to merge
5
commits into
dapr:main
Choose a base branch
from
ZeynelKoca:dynamo-global-ttl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
29f9eeb
Global ttlInSeconds metadata configuration for DynamoDb
ZeynelKoca 9102a8e
Document new property
ZeynelKoca 031a050
Unit tests
ZeynelKoca a2acca8
Merge main into dynamo-global-ttl branch - resolve conflicts
ZeynelKoca 59ef1d4
Merge branch 'main' into dynamo-global-ttl
sicoyle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -36,6 +36,12 @@ metadata: | |||||||||
The table attribute name which should be used for TTL. | ||||||||||
example: '"expiresAt"' | ||||||||||
type: string | ||||||||||
- name: ttlInSeconds | ||||||||||
required: false | ||||||||||
description: | | ||||||||||
Allows specifying a default Time-to-live (TTL) in seconds that will be applied to every state store request unless TTL is explicitly defined via the request metadata. | ||||||||||
Comment on lines
+41
to
+42
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
example: '"600"' | ||||||||||
type: number | ||||||||||
- name: partitionKey | ||||||||||
required: false | ||||||||||
description: | | ||||||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test case demonstrates that the behavior for dynamodb would make the setting of this metadata field to 0 to expire immediately, and the same for a negative value. However, if I look at the SET implementation of the redis implementation a value of 0 for the ttl means the key never expires, as does a negative value. I think we should have the same behavior on dynamodb that we have for redis please 🙏 If you can also create a docs PR to add this PR to the docs too that would be greatly appreciated! Feel free to tag me when this is ready for re-review :)
https://github.com/berndverst/components-contrib/blob/master/state/redis/redis.go#L363