Skip to content

Conversation

@tmiddlet2666
Copy link

Description

Added a new implementation for a Coherence state store component.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@tmiddlet2666 tmiddlet2666 requested review from a team as code owners June 5, 2025 03:40
@tmiddlet2666
Copy link
Author

Hi @JoshVanL @daixiang0
Creating this new PR to replace the old one which i will close.
There were too many conflicts in my manual merge

@tmiddlet2666
Copy link
Author

Hi @JoshVanL @daixiang0
Anything more i need to do here, thanks?

Copy link
Contributor

@nelson-parente nelson-parente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm! added some nits

Signed-off-by: Tim Middleton <[email protected]>
@tmiddlet2666
Copy link
Author

Thanks @nelson-parente
I have pushed updated code to address review comments.

nelson-parente
nelson-parente previously approved these changes Jun 17, 2025
@tmiddlet2666
Copy link
Author

@JoshVanL @daixiang0
Please let me know if any more changes are required now @nelson-parente has approved
Thanks

@tmiddlet2666
Copy link
Author

Any more changes required here? Can we can this approved and merged please?
Thanks

@cicoyle cicoyle added the documentation required This issue needs documentation label Jun 25, 2025
cicoyle
cicoyle previously approved these changes Jun 25, 2025
Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one typo nit, but otherwise lgtm

Co-authored-by: Cassie Coyle <[email protected]>
Signed-off-by: Tim Middleton <[email protected]>
@tmiddlet2666 tmiddlet2666 dismissed stale reviews from cicoyle and nelson-parente via 664bb0d June 26, 2025 00:52
@yaron2 yaron2 merged commit 73da167 into dapr:main Jun 26, 2025
90 of 91 checks passed
@tmiddlet2666 tmiddlet2666 deleted the coherence-v2 branch June 26, 2025 04:46
@yaron2
Copy link
Member

yaron2 commented Jun 26, 2025

@tmiddlet2666 Please follow up with a docs PR to add this to our docs. See an example here: dapr/docs#4691

@tmiddlet2666
Copy link
Author

@tmiddlet2666 Please follow up with a docs PR to add this to our docs. See an example here: dapr/docs#4691

Thanks @yaron2
I have created a doc issue for my previous PR dapr/docs#4661
Will look at the above example.
Thanks

mikeee pushed a commit to mikeee/dapr_components-contrib that referenced this pull request Jun 27, 2025
Signed-off-by: Tim Middleton <[email protected]>
Co-authored-by: Nelson Parente <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
sicoyle pushed a commit to sicoyle/components-contrib that referenced this pull request Jul 7, 2025
Signed-off-by: Tim Middleton <[email protected]>
Co-authored-by: Nelson Parente <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation required This issue needs documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants