-
Notifications
You must be signed in to change notification settings - Fork 543
Add coherence state store component - updated #3838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Tim Middleton <[email protected]>
|
Hi @JoshVanL @daixiang0 |
|
Hi @JoshVanL @daixiang0 |
nelson-parente
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm! added some nits
Signed-off-by: Tim Middleton <[email protected]>
|
Thanks @nelson-parente |
|
@JoshVanL @daixiang0 |
|
Any more changes required here? Can we can this approved and merged please? |
cicoyle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one typo nit, but otherwise lgtm
Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: Tim Middleton <[email protected]>
664bb0d
|
@tmiddlet2666 Please follow up with a docs PR to add this to our docs. See an example here: dapr/docs#4691 |
Thanks @yaron2 |
Signed-off-by: Tim Middleton <[email protected]> Co-authored-by: Nelson Parente <[email protected]> Co-authored-by: Cassie Coyle <[email protected]>
Signed-off-by: Tim Middleton <[email protected]> Co-authored-by: Nelson Parente <[email protected]> Co-authored-by: Cassie Coyle <[email protected]>
Description
Added a new implementation for a Coherence state store component.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: