DeleteWithPrefix support for SQLite #3265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Lettieri <[email protected]>
Signed-off-by: Ryan Lettieri <[email protected]>
Signed-off-by: Ryan Lettieri <[email protected]>
Signed-off-by: Ryan Lettieri <[email protected]>
Signed-off-by: Ryan Lettieri <[email protected]>
Signed-off-by: Ryan Lettieri <[email protected]>
ItalyPaleAle
changed the title
Open
5 tasks
Co-authored-by: Alessandro (Ale) Segala <[email protected]> Signed-off-by: Ryan Lettieri <[email protected]>
ItalyPaleAle
approved these changes
Dec 14, 2023
ItalyPaleAle
suggested changes
Dec 14, 2023
There was a problem hiding this comment.
Cert tests for SQLite are failing: https://github.com/dapr/components-contrib/actions/runs/7213589568/job/19653804608?pr=3265
Signed-off-by: Alessandro (Ale) Segala <[email protected]>
Also added script to update the artifact in the future Signed-off-by: ItalyPaleAle <[email protected]>
…o delete-actor-supprt
Signed-off-by: Ryan Lettieri <[email protected]>
ItalyPaleAle
approved these changes
Dec 18, 2023
|
LGTM, thanks @RyanLettieri ! |
ItalyPaleAle
added a commit
to ItalyPaleAle/dapr-components-contrib
that referenced
this pull request
Jan 17, 2024
The feature is not landing in Dapr 1.13 so removing the code from the SQLite component to avoid adding a migration we are not (yet) going to be using. This PR **partially** reverts dapr#3265 (at least, the parts related to the component itself) After this PR is merged, I'll open a PR *reverting this PR* that can be slated for 1.14 Signed-off-by: ItalyPaleAle <[email protected]>
ItalyPaleAle
added a commit
to ItalyPaleAle/dapr-components-contrib
that referenced
this pull request
Jan 17, 2024
The feature is not landing in Dapr 1.13 so removing the code from the SQLite component to avoid adding a migration we are not (yet) going to be using. This PR **partially** reverts dapr#3265 (at least, the parts related to the component itself) After this PR is merged, I'll open a PR *reverting this PR* that can be slated for 1.14 Signed-off-by: ItalyPaleAle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added in optional interface for state stores to allow for deletion of actor state.
Implemented this functionality inside sqlite as a proof of concept.
Related to: dapr/dapr#7223
Related to: #3262
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[3262]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: