Skip to content

Addition of Purge for workflow #2729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artursouza merged 10 commits into from
Apr 25, 2023
Merged

Addition of Purge for workflow #2729

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
99a39e3
Addition of Purge for workflow
RyanLettieri Mar 29, 2023
27a6463
merging master
RyanLettieri Apr 6, 2023
3a71e08
Merge branch 'dapr:master' into workflow-purge
RyanLettieri Apr 13, 2023
13db14c
Merge branch 'master' into workflow-purge
RyanLettieri Apr 19, 2023
426225d
Merge branch 'dapr:master' into workflow-purge
RyanLettieri Apr 19, 2023
c000ca6
Merge branch 'master' into workflow-purge
RyanLettieri Apr 20, 2023
2dc5384
Merging in master
RyanLettieri Apr 24, 2023
fb34198
Merge branch 'workflow-purge' of https://github.com/RyanLettieri/comp…
RyanLettieri Apr 24, 2023
1bca24a
Updating json reference for purgerequest for consistency
RyanLettieri Apr 25, 2023
66eb93a
Tidy
RyanLettieri Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions workflows/requests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,8 @@ type PauseRequest struct {
type ResumeRequest struct {
InstanceID string `json:"instanceID"`
}

// PurgeRequest is the object describing a Purge request.
type PurgeRequest struct {
InstanceID string `json:"workflow_reference"`
Comment thread
RyanLettieri marked this conversation as resolved.
Outdated
}
5 changes: 5 additions & 0 deletions workflows/temporal/temporal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,11 @@ func (c *TemporalWF) RaiseEvent(ctx context.Context, req *workflows.RaiseEventRe
return c.client.SignalWorkflow(ctx, req.InstanceID, "", req.EventName, decodedEventData)
}

func (c *TemporalWF) Purge(ctx context.Context, req *workflows.PurgeRequest) error {
// Unimplemented
return nil
}

func (c *TemporalWF) Close() {
c.client.Close()
}
Expand Down
1 change: 1 addition & 0 deletions workflows/workflow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ type Workflow interface {
Terminate(ctx context.Context, req *TerminateRequest) error
Get(ctx context.Context, req *GetRequest) (*StateResponse, error)
RaiseEvent(ctx context.Context, req *RaiseEventRequest) error
Purge(ctx context.Context, req *PurgeRequest) error
Pause(ctx context.Context, req *PauseRequest) error
Resume(ctx context.Context, req *ResumeRequest) error
GetComponentMetadata() map[string]string
Expand Down