Merged
Conversation
Since dapphub/ds-test#30 calls to `failed()` can contain reverting branches due to the call into abi.decode(). This meant that using prove tests with the latest ds-test version would always fail with a hard error. This change updates the symbolic test stepper to correctly report `bailed` as true for branches that reverted during the call to `failed()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since dapphub/ds-test#30 calls to
failed()cancontain reverting branches due to the call into abi.decode().
This meant that using prove tests with the latest ds-test version would
always fail with a hard error.
This change updates the symbolic test stepper to correctly report
bailedas true for branches that reverted during the call tofailed().Description
Checklist