Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit variant errors in the hot loop #36

Merged
merged 7 commits into from
Dec 27, 2023
Merged

Unit variant errors in the hot loop #36

merged 7 commits into from
Dec 27, 2023

Conversation

dantheman3333
Copy link
Owner

@dantheman3333 dantheman3333 commented Dec 23, 2023 •
edited
Loading

Updates the parsing code to have simple unit variant errors in the hot loop, speeding up bag reading by ~100ms (573ms -> 430ms).
Other updates:

@dantheman3333 dantheman3333 marked this pull request as ready for review December 27, 2023 19:18
@dantheman3333 dantheman3333 merged commit 9c53e37 into master Dec 27, 2023
2 checks passed
@dantheman3333 dantheman3333 deleted the dk-new-errors branch December 27, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance regression in Rust 1.71
1 participant
@dantheman3333