Add video bundle #115
Merged
Add video bundle #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used in the video budle component
…gurations This division mimics the two different ways this component will be receiving data from Drupal backend.
…n VideoBundle.stories.tsx
A11y accessibility is having troubles seeing the proper colors of these texts.
In hopes to make our accessibility tests find accessibility issues
This was introduced to find out whether our accessibility tests work. (spoiler alert: they still don't. I am making a ticket for it)
Adamik10
force-pushed
the
DDFBRA-280-style-video-bundle-paragraph
branch
from
33435ba to
4be2848
Compare
Instead of depricated url prop.
To match the design
We now just provide works to the parent component and render WorkCard as components inside WorkCardStacked
This is for the use case of no works to cycle through in the video bundle. Then the timer doesn't progress.
The color contrast wasn't good enough for the text.
& move the logic that alternates between the automatic version and manual version into parent components - VideoBundleAutomatic and VideoBundleManual This is a better structure - clears out the code and keep to the rule of one component does one thing. Also stories were edited to match.
ThomasGross
requested changes
Feb 13, 2025
In order to make the component have a single purpose we divide it into multiple components that each have their own responsibility. Introduces WorkCardWithCaption.tsx + we wrap the card in a link if it needs to be linking somewhere (instead of having the link as a part of the component.
After the TW upgrade the current implementation didn't wok, due to the color being used not existing in our color definitions.
ThomasGross
requested changes
Feb 13, 2025
To simplify the component.
"Go to the work of x by y"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFBRA-280
Description
This PR adds support to the video bundle paragraph we can get from drupal.
This PR also adds new variants of the Font.stories.tsx in order to be able to check accessibility for fonts on various backgrounds.
Screenshot of the result
These are now a bit outdated screenshots. I aligned the stacked cards and buttons to the grid and each other since the screenshot was taken, but you get the gist.
Mobile:
Additional comments or questions
We as of now can't properly show the Video Bundle stories in GH in order to Chromatic test them due to not mocking API calls in storybook yet. There is a separate task for it that will be solved in the future.