Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration Fixes #126

Merged
merged 7 commits into from
Aug 10, 2020
Merged

Registration Fixes #126

merged 7 commits into from
Aug 10, 2020

Conversation

dansiegel
Copy link
Owner

Description

This PR fixes some issues related to #124 and is a replacement to #115

Changes

  • Fixes default DryIoc rules to allow appending
  • Updates Register keyed to explicitly replace the previous registration
  • Fixes Microsoft.Extensions.DependencyInject wrapper to ensure we construct unregistered concrete types as a transient.
  • Adds tests for Multiple Registrations and Resolve IEnumerable

Notes

This does not solve #125. The Unity Container implementation does not currently support this behavior.

@dansiegel dansiegel marked this pull request as ready for review August 10, 2020 21:49
@dansiegel dansiegel merged commit 04275b3 into master Aug 10, 2020
@dansiegel dansiegel deleted the register-fixes branch August 10, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant